Skip to content

Conversation

@maxreichmann
Copy link
Contributor

@maxreichmann maxreichmann commented Dec 6, 2024

JIRA: CPOUI5FOUNDATION-967
Dev Guide to Test Starter: https://ui5.sap.com/#/topic/032be2cb2e1d4115af20862673bedcdb


Changes in every exercise:

  • Update app code to use Test Starter
  • Update documentation in README.md
  • Update ui5.yaml config
  • Update deps in package.json

Exercises done:

  • ex0
  • ex1
  • ex2
  • ex3
  • ex4
  • ex5
  • ex6

Note:
Tests of ex1 and ex6 are runnable and pass.
Tests of ex2 to ex5 are also runnable. But since these tests didn't pass in the original version of this tutorial, they cannot pass now.

Misc. Changes:

  • docs(ex0): Replace command for retrieving the version of the installed generator-easy-ui5 npm package

Generator Template:

  • Migrate generator/generators/app/templates to use Test Starter

@maxreichmann maxreichmann force-pushed the migrate-to-test-starter branch from 0caff22 to 8470285 Compare December 9, 2024 17:24
@maxreichmann maxreichmann marked this pull request as ready for review December 9, 2024 17:26
@akudev akudev self-requested a review December 9, 2024 18:36

```sh
npm info generator-easy-ui5 version
npm list -g "generator-easy-ui5"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

@akudev akudev merged commit 2565b2c into SAP-samples:main Dec 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants