Skip to content

fix job console missing#173

Merged
ib-steffen merged 3 commits intoSAP:masterfrom
iberryful:master
Oct 19, 2018
Merged

fix job console missing#173
ib-steffen merged 3 commits intoSAP:masterfrom
iberryful:master

Conversation

@iberryful
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Contributor

@ib-steffen ib-steffen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have the same problems in handle_timeout() and handle_abort(). I think we should fix them all together.

Comment thread src/scheduler/kubernetes/scheduler.py
@iberryful
Copy link
Copy Markdown
Member Author

  1. For upload_console
    avoid empty console by mistake
  2. For handle_timeouts
    it's ok not to restrict the scheduler to jobs belongs to itself because kube_delete_job will ignore jobs that are not belong to itself and upload_console is protected by transaction. Setting state to error will apply only to jobs with running state.
  3. For handle_aborts
    I removed filtering jobs on cluster_name because jobs will not be handle if one cluster is down if we only allow scheduler to schedule jobs belong to itself.

@ib-steffen ib-steffen merged commit 4ca01f9 into SAP:master Oct 19, 2018
AurelienCaille pushed a commit to AurelienCaille/InfraBox that referenced this pull request Oct 22, 2018
AurelienCaille pushed a commit to AurelienCaille/InfraBox that referenced this pull request Oct 22, 2018
* fix job console missing

* also update handle_timeouts and handle_aborts

* use transaction to protect console output
AurelienCaille pushed a commit to AurelienCaille/InfraBox that referenced this pull request Oct 23, 2018
* fix job console missing

* also update handle_timeouts and handle_aborts

* use transaction to protect console output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants