Skip to content

Conversation

@MatKuhr
Copy link
Member

@MatKuhr MatKuhr commented Sep 17, 2024

Context

See https://github.wdf.sap.corp/AI/apis/issues/79

Definition of Done

  • Functionality scope stated & covered
  • Tests cover the scope above
  • Error handling created / updated & covered by the tests above
  • Aligned changes with the JavaScript SDK
  • Documentation updated
  • Release notes updated

if (!resources.getCustomFieldNames().contains("backend_details")) {
return false;
Object detailsObject = resources.getBackendDetails();
// workaround for https://jira.tools.sap/browse/AIWDF-2124
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add TODO to the comment. Also I was told to remove internal links on this repo.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding a todo makes the build fail..

Co-authored-by: Charles Dubois <103174266+CharlesDuboisSAP@users.noreply.github.com>
@MatKuhr MatKuhr merged commit 5ea851a into main Sep 19, 2024
@MatKuhr MatKuhr deleted the chore/prepare-backend-details-fix branch September 19, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants