chore: [DevOps] Add PMD rules for public API exposure of model types#777
Merged
chore: [DevOps] Add PMD rules for public API exposure of model types#777
Conversation
…class-level restrictions
newtork
reviewed
Mar 2, 2026
newtork
reviewed
Mar 2, 2026
newtork
previously approved these changes
Mar 2, 2026
Contributor
newtork
left a comment
There was a problem hiding this comment.
Looks good to me.
I would say let's try it out! If we encounter false-positives or decide to no longer care - we can still remove the pmd rule without issues.
Co-authored-by: Alexander Dümont <alexander.duemont@sap.com>
Co-authored-by: Alexander Dümont <alexander.duemont@sap.com>
newtork
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This PR introduces new PMD rules to check whether code from
.modelpackages get exposed in public API.It flags the following:
Warnings about current violations of these rules are suppressed.
Feature scope:
Definition of Done
Tests cover the scope aboveError handling created / updated & covered by the tests aboveAligned changes with the JavaScript SDKDocumentation updatedRelease notes updated