chore: Improve service owner tests and add deletion jobs#802
chore: Improve service owner tests and add deletion jobs#802
Conversation
Are you saying, developers outside the java team have write access to the SAP Cloud SDK for AI for Java?
Was this aligned with the java team already? We already had long-running open PRs due to alignment / merge conflicts - e.g. grounding. Orchestration branch alignment may even take longer. 90 days seems long enough, but looks rather arbitrary to me. |
Yes, this is the minimum access needed to trigger workflows. Currently we share a PAT from an admin user, which is worse. @CharlesDuboisSAP and I already aligned on this.
Yes 90 days is arbitrary and we didn't align on this. I chose 90 days because it is close to a quarter and I assume most cases will be more than covered by this.
|
Co-authored-by: Charles Dubois <103174266+CharlesDuboisSAP@users.noreply.github.com>
Context
This PR does the same as SAP/ai-sdk-js#1676 only for Java.
This improves the test setup as follows:
security
branch deletion
refactoring
fileandfile-refwere renamed toserviceandrefI did not apply the "auth check" to any jobs. It is up to you if you want to use this and where.