Skip to content

fix: [Grounding] test#832

Merged
newtork merged 1 commit intomainfrom
fix/grounding-test
Apr 22, 2026
Merged

fix: [Grounding] test#832
newtork merged 1 commit intomainfrom
fix/grounding-test

Conversation

@newtork
Copy link
Copy Markdown
Contributor

@newtork newtork commented Apr 21, 2026

MatchMode cannot be null ffs

@newtork newtork added the please-review Request to review a pull-request label Apr 21, 2026
@Jonas-Isr
Copy link
Copy Markdown
Member

Jonas-Isr commented Apr 22, 2026

MatchMode cannot be null ffs

But it is nullable: true here. Did you tell them that their spec is wrong? Or am I missing something?

@newtork
Copy link
Copy Markdown
Contributor Author

newtork commented Apr 22, 2026

Good catch! I updated my report in slack support channel

@newtork newtork merged commit 8494327 into main Apr 22, 2026
6 checks passed
@newtork newtork deleted the fix/grounding-test branch April 22, 2026 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jonas-Isr Jonas-Isr Jonas-Isr approved these changes

Assignees

No one assigned

Labels

please-review Request to review a pull-request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@newtork @Jonas-Isr