Refactoring and adding of tracing #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this commit contains most of the work to refactor and improve the logging library. It also contains the first tracing implementation with sap passport.
KarstenSchnitter
approved these changes
Dec 14, 2020
Contributor
KarstenSchnitter
left a comment
KarstenSchnitter
left a comment
There was a problem hiding this comment.
LGTM. As far as I understand. I like the sap_passport.js.
Contributor
Author
|
I think I forgot to update the Documentation to also mention sap_passport, will do so also |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit contains most of the work to refactor
and improve the logging library.
It also contains the first tracing implementation with sap passport.