You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
IAS doesn't allow for sending clientid:client-id:apptid:tenant-id. We might have built this based on some older documentation from IAS that in the meanwhile got updated. Or I made a copy/paste mistake when copying the requirements for the parameters into our ticket 😅
Anyhow, deprecating the non-functional option.
Definition of Done
Functionality scope stated & covered
Tests cover the scope above
Error handling created / updated & covered by the tests above
Why don't you remove it all together since it's @beta
Yeah I was considering that too, but figured I don't want to spend more time thinking if this could somehow break something. It should probably be fine, since it's non-functional currently, but breaking API changes are always a bit dangerous. No strong opinion though TBH.
I could also already prepare a PR and add it to the September BLI 😄
Why don't you remove it all together since it's @beta
Yeah I was considering that too, but figured I don't want to spend more time thinking if this could somehow break something. It should probably be fine, since it's non-functional currently, but breaking API changes are always a bit dangerous. No strong opinion though TBH.
I could also already prepare a PR and add it to the September BLI 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MatKuhr
added
please merge
Context
SAP/cloud-sdk-java-backlog#454
IAS doesn't allow for sending
clientid:client-id:apptid:tenant-id. We might have built this based on some older documentation from IAS that in the meanwhile got updated. Or I made a copy/paste mistake when copying the requirements for the parameters into our ticket 😅Anyhow, deprecating the non-functional option.
Definition of Done
Error handling created / updated & covered by the tests above