fix: (odata-client) Move disable-buffer toggle from result object to request builder

[newtork]

Context

https://github.com/SAP/cloud-sdk-java-backlog/issues/481

Please provide a short description of what your change does and why it is needed.

Feature scope:

For Generic OData Client:

• Switch default behavior for HttpResponse entity from lazy-buffered to `eagerly-buffered.
• Switch optional feature toggle from disableBufferingHttpResponse() on ODataRequestResultGeneric to withoutResponseBuffering() on ODataRequestRead and ODataRequestReadByKey.
• Deprecate legacy API, mark new API unstable.

Definition of Done

• Functionality scope stated & covered
• Tests cover the scope above
• Error handling created / updated & covered by the tests above
• Documentation updated
• Release notes updated

[MatKuhr]

productive code largely LGTM, didn't look at tests yet. I like the non-breaking introduction of AutoClosable, even though it comes at the cost of some new API.

If we want to reduce new API a bit, we could consider adding executeOpen() to ODataRequestExecutable. That would have the downside that this is also on Batch, where then both execute and executeOpen behave the same (since changing execute to now start buffering would be a breaking change 🙁)

But maybe we can somewhere make clearer, that this solution not only buffers, but eagerly buffers. It's good for understanding the importance of having both, as you pointed out 😉

[MatKuhr]

This effectively means that withoutResponseBuffering() will be the last method before executing, but I think that is an acceptable small limitation

[MatKuhr]

tests LGTM 👍🏻

[rpanackal]

I have reviewed low level api changes. Overall looks good to me.

Same concern as @MatKuhr on logging failed buffering of http entity.

That said, I haven't previously looked at this module deeply. So not sure if I missed anything.

[MatKuhr]

otherwise lgtm