chore: Add composite setup action for pnpm by davidkna-sap · Pull Request #6507 · SAP/cloud-sdk-js

davidkna-sap · 2026-04-17T08:02:00Z

Add composite setup action for pnpm

…etup action

marikaner · 2026-04-20T06:46:51Z

+    description: 'Node.js version'
+    default: '22'
+  registry-url:
+    description: 'The registry URL to use for npm packages. Defaults to the SAP Artifactory mirror when npm-token is provided, otherwise npmjs.'


[q] I assume the fallback to npmjs is there for external contributors? If that is the case, why do we even have configuration for it? Apparently it is never used anyways. Also, I fear that it is too easy to forget passing the token and then you never use artifactory at all.

I didn't think this through to the end, but what do you think about checking what repo this is running on aka if: github.repository == 'SAP/cloud-sdk-js' then require a token and fail if not passed, otherwise if no token passed use npmjs.org.

This is also for moving back to the main npm registry for release builds, see SAP/ai-sdk-js#1749

Makes sense. Then, how about the following:

we leave both inputs registry-url and registry-token

by default we check if: github.repository == 'SAP/cloud-sdk-js' then require a token for artifactory and fail if not passed, otherwise if no token passed use npmjs.org

if a registry-url was passed on SAP/cloud-sdk-js use it as passed

Also, as this is used in ai-sdk-js as well, maybe we include both in here (now it's getting ugly) or check for the SAP org only (okish, because all projects should use SAP artifactory anyways).
What do you think?

@marikaner Doesn't this match the way it is currently implemented?

Haha, I just saw, that you already implemented it in a similar way 😊

marikaner · 2026-04-20T06:48:48Z

+    - uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
+      with:
+        node-version: ${{ inputs.node-version }}
+        registry-url: ${{ inputs.registry-url != '' && inputs.registry-url || (inputs.npm-token != '' && 'https://common.repositories.cloud.sap/artifactory/api/npm/build.releases.npm/' || 'https://registry.npmjs.org') }}


[req] Whatever we decide the logic to be here, let's put this into a separate step with proper outputs for better readability and maintainability.

…oken removal

marikaner

I like this better. Although I have one small request still, I already approved as it should not be a blocker.

marikaner · 2026-04-21T07:37:34Z

+        elif [[ -n "$REGISTRY_TOKEN" ]]; then
+          echo "url=https://common.repositories.cloud.sap/artifactory/api/npm/build.releases.npm/" >> $GITHUB_OUTPUT


I like this better now, because you have to set one of the values at least, making it safe against forgetfulness.
[pp] One possible issue though: When both are set, the URL is now overwritten. I would prefer that not to happen.

* origin/main: chore(deps): bump follow-redirects from 1.15.11 to 1.16.0 (#6495) chore: Add composite setup action for pnpm (#6507) fix: Avoid caching jwt if it needs to be forwarded (#6007) Change status from proposed to decided chore(deps): bump typescript-eslint from 8.58.1 to 8.58.2 (#6514) chore(deps): bump @typescript-eslint/parser from 8.58.1 to 8.58.2 (#6513) chore(deps-dev): bump @sap/cds-dk from 9.8.3 to 9.8.4 (#6512) chore(deps): bump fast-xml-parser from 5.5.11 to 5.6.0 (#6509) chore(deps-dev): bump puppeteer from 24.40.0 to 24.41.0 (#6508)

…eckapi * origin/main: chore: Refactor test imports to use @sap-cloud-sdk/test-util-internal pkg (#6467) chore: Add license-checker action for pnpm (#6473) chore(deps): bump follow-redirects from 1.15.11 to 1.16.0 (#6495) chore: Add composite setup action for pnpm (#6507) fix: Avoid caching jwt if it needs to be forwarded (#6007) Change status from proposed to decided chore(deps): bump typescript-eslint from 8.58.1 to 8.58.2 (#6514) chore(deps): bump @typescript-eslint/parser from 8.58.1 to 8.58.2 (#6513) chore(deps-dev): bump @sap/cds-dk from 9.8.3 to 9.8.4 (#6512) chore(deps): bump fast-xml-parser from 5.5.11 to 5.6.0 (#6509) chore(deps-dev): bump puppeteer from 24.40.0 to 24.41.0 (#6508)

* origin/main: chore(check-public-api): Use tempdir instead of mockfs (#6468) chore(deps): bump prettier from 3.8.2 to 3.8.3 (#6510) chore: Refactor test imports to use @sap-cloud-sdk/test-util-internal pkg (#6467) chore: Add license-checker action for pnpm (#6473) chore(deps): bump follow-redirects from 1.15.11 to 1.16.0 (#6495) chore: Add composite setup action for pnpm (#6507) fix: Avoid caching jwt if it needs to be forwarded (#6007) Change status from proposed to decided chore(deps): bump typescript-eslint from 8.58.1 to 8.58.2 (#6514) chore(deps): bump @typescript-eslint/parser from 8.58.1 to 8.58.2 (#6513) chore(deps-dev): bump @sap/cds-dk from 9.8.3 to 9.8.4 (#6512) chore(deps): bump fast-xml-parser from 5.5.11 to 5.6.0 (#6509) chore(deps-dev): bump puppeteer from 24.40.0 to 24.41.0 (#6508)

* origin/main: chore(check-public-api): Use tempdir instead of mockfs (#6468) chore(deps): bump prettier from 3.8.2 to 3.8.3 (#6510) chore: Refactor test imports to use @sap-cloud-sdk/test-util-internal pkg (#6467) chore: Add license-checker action for pnpm (#6473) chore(deps): bump follow-redirects from 1.15.11 to 1.16.0 (#6495) chore: Add composite setup action for pnpm (#6507) fix: Avoid caching jwt if it needs to be forwarded (#6007) Change status from proposed to decided chore(deps): bump typescript-eslint from 8.58.1 to 8.58.2 (#6514) chore(deps): bump @typescript-eslint/parser from 8.58.1 to 8.58.2 (#6513) chore(deps-dev): bump @sap/cds-dk from 9.8.3 to 9.8.4 (#6512) chore(deps): bump fast-xml-parser from 5.5.11 to 5.6.0 (#6509) chore(deps-dev): bump puppeteer from 24.40.0 to 24.41.0 (#6508) chore(deps-dev): bump typedoc from 0.28.18 to 0.28.19 (#6505)

…e-and-write-changelogs * origin/main: (36 commits) chore: Replace mock-fs with memfs/unionfs for fs mocking (#6470) chore(deps-dev): bump @changesets/cli from 2.30.0 to 2.31.0 (#6515) chore(deps): bump bignumber.js from 10.0.2 to 11.0.0 (#6511) chore(deps): bump @changesets/get-release-plan from 4.0.15 to 4.0.16 (#6518) chore(check-public-api): Use tempdir instead of mockfs (#6468) chore(deps): bump prettier from 3.8.2 to 3.8.3 (#6510) chore: Refactor test imports to use @sap-cloud-sdk/test-util-internal pkg (#6467) chore: Add license-checker action for pnpm (#6473) chore(deps): bump follow-redirects from 1.15.11 to 1.16.0 (#6495) chore: Add composite setup action for pnpm (#6507) fix: Avoid caching jwt if it needs to be forwarded (#6007) Change status from proposed to decided chore(deps): bump typescript-eslint from 8.58.1 to 8.58.2 (#6514) chore(deps): bump @typescript-eslint/parser from 8.58.1 to 8.58.2 (#6513) chore(deps-dev): bump @sap/cds-dk from 9.8.3 to 9.8.4 (#6512) chore(deps): bump fast-xml-parser from 5.5.11 to 5.6.0 (#6509) chore(deps-dev): bump puppeteer from 24.40.0 to 24.41.0 (#6508) chore(deps-dev): bump typedoc from 0.28.18 to 0.28.19 (#6505) chore(deps): bump ts-morph from 27.0.2 to 28.0.0 (#6506) chore(deps-dev): bump globals from 17.4.0 to 17.5.0 (#6504) ...

* origin/main: (27 commits) chore: Replace mock-fs with memfs/unionfs for fs mocking (#6470) chore(deps-dev): bump @changesets/cli from 2.30.0 to 2.31.0 (#6515) chore(deps): bump bignumber.js from 10.0.2 to 11.0.0 (#6511) chore(deps): bump @changesets/get-release-plan from 4.0.15 to 4.0.16 (#6518) chore(check-public-api): Use tempdir instead of mockfs (#6468) chore(deps): bump prettier from 3.8.2 to 3.8.3 (#6510) chore: Refactor test imports to use @sap-cloud-sdk/test-util-internal pkg (#6467) chore: Add license-checker action for pnpm (#6473) chore(deps): bump follow-redirects from 1.15.11 to 1.16.0 (#6495) chore: Add composite setup action for pnpm (#6507) fix: Avoid caching jwt if it needs to be forwarded (#6007) Change status from proposed to decided chore(deps): bump typescript-eslint from 8.58.1 to 8.58.2 (#6514) chore(deps): bump @typescript-eslint/parser from 8.58.1 to 8.58.2 (#6513) chore(deps-dev): bump @sap/cds-dk from 9.8.3 to 9.8.4 (#6512) chore(deps): bump fast-xml-parser from 5.5.11 to 5.6.0 (#6509) chore(deps-dev): bump puppeteer from 24.40.0 to 24.41.0 (#6508) chore(deps-dev): bump typedoc from 0.28.18 to 0.28.19 (#6505) chore(deps): bump ts-morph from 27.0.2 to 28.0.0 (#6506) chore(deps-dev): bump globals from 17.4.0 to 17.5.0 (#6504) ...

chore: Add composite setup action for pnpm

08a376d

marikaner requested changes Apr 17, 2026

View reviewed changes

Comment thread .github/actions/setup/action.yml Outdated

Comment thread .github/actions/setup/action.yml

Comment thread .github/actions/setup/action.yml Outdated

Comment thread .github/actions/setup/action.yml Outdated

davidkna-sap added 3 commits April 17, 2026 10:43

simplify setup action

38aef27

chore: Rename npm-token to registry-token in setup action

7342f5f

chore: Remove default values for registry-url and registry-token in s…

cd29279

…etup action

davidkna-sap marked this pull request as ready for review April 17, 2026 11:13

davidkna-sap requested a review from marikaner April 17, 2026 11:14

davidkna-sap mentioned this pull request Apr 17, 2026

chore: Use npm-mirror in CI and use dependency cooldown for smoke test SAP/ai-sdk-js#1749

Merged

marikaner reviewed Apr 20, 2026

View reviewed changes

chore: Enhance registry URL resolution logic in setup action

e211da9

davidkna-sap requested a review from marikaner April 20, 2026 08:10

davidkna-sap added 2 commits April 21, 2026 08:43

chore: Skip lifecycle scripts during pnpm install and rebuild after t…

62a768d

…oken removal

simplify error printing

6dd9d65

marikaner approved these changes Apr 21, 2026

View reviewed changes

Improve registry resolution

f81946b

marikaner merged commit 0ffc5c8 into main Apr 21, 2026
15 checks passed

marikaner deleted the pnpm-setup branch April 21, 2026 08:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Add composite setup action for pnpm#6507

chore: Add composite setup action for pnpm#6507
marikaner merged 8 commits intomainfrom
pnpm-setup

davidkna-sap commented Apr 17, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marikaner Apr 20, 2026

Uh oh!

davidkna-sap Apr 20, 2026

Uh oh!

marikaner Apr 21, 2026

Uh oh!

davidkna-sap Apr 21, 2026

Uh oh!

marikaner Apr 21, 2026

Uh oh!

marikaner Apr 20, 2026

Uh oh!

marikaner left a comment

Uh oh!

marikaner Apr 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		elif [[ -n "$REGISTRY_TOKEN" ]]; then
		echo "url=https://common.repositories.cloud.sap/artifactory/api/npm/build.releases.npm/" >> $GITHUB_OUTPUT

Conversation

davidkna-sap commented Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marikaner Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

davidkna-sap Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

marikaner Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

davidkna-sap Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

marikaner Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

marikaner Apr 20, 2026

Choose a reason for hiding this comment

Uh oh!

marikaner left a comment

Choose a reason for hiding this comment

Uh oh!

marikaner Apr 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

davidkna-sap commented Apr 17, 2026 •

edited

Loading