Skip to content

feat(telemetry): middleware for propagating telemetry from requests#84

Merged
LucasAlvesSoares merged 16 commits intomainfrom
agw-middleware
Apr 29, 2026
Merged

feat(telemetry): middleware for propagating telemetry from requests#84
LucasAlvesSoares merged 16 commits intomainfrom
agw-middleware

Conversation

@LucasAlvesSoares
Copy link
Copy Markdown
Contributor

@LucasAlvesSoares LucasAlvesSoares commented Apr 28, 2026

Description

Introduced support to middlewares for enriching auto instrumentation as well as a built-in A2A Starlette middleware for IAS info

Type of Change

Please check the relevant option:

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code refactoring
  • Dependency update

How to Test

Describe how reviewers can test your changes:

  1. Create a StarletteA2A-based agent
  2. Create the newly implemented middleware
  3. Add this middleware to auto instrumentation
  4. Send a request with an authorization header with a jwt containing user_uuid and sap_gtid claims
  5. Watch telemetry contain the respective attributes

Checklist

Before submitting your PR, please review and check the following:

  • I have read the Contributing Guidelines
  • I have verified that my changes solve the issue
  • I have added/updated automated tests to cover my changes
  • All tests pass locally
  • I have verified that my code follows the Code Guidelines
  • I have updated documentation (if applicable)
  • I have added type hints for all public APIs
  • My code does not contain sensitive information (credentials, tokens, etc.)
  • I have followed Conventional Commits for commit messages

@LucasAlvesSoares LucasAlvesSoares marked this pull request as ready for review April 28, 2026 21:04
@LucasAlvesSoares LucasAlvesSoares requested a review from a team as a code owner April 28, 2026 21:04
Comment thread src/sap_cloud_sdk/core/telemetry/constants.py Outdated
Copy link
Copy Markdown
Member

@jeanscherf jeanscherf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LucasAlvesSoares LucasAlvesSoares merged commit 9cc450a into main Apr 29, 2026
10 of 11 checks passed
@LucasAlvesSoares LucasAlvesSoares deleted the agw-middleware branch April 29, 2026 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants