Skip to content

&1 attributes reach threshold of &2 #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 9, 2020
Merged

&1 attributes reach threshold of &2 #168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8b8f062
%261 reach threshold of %262
lucasborin Oct 7, 2020
ae372a0
reach => reaching
lucasborin Oct 8, 2020
6495cb2
minor fixes
lucasborin Oct 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/checks/y_check_num_exec_statements.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ CLASS Y_CHECK_NUM_EXEC_STATEMENTS IMPLEMENTATION.

add_obj_type( c_type_program ).

set_check_message( '&1 executable statements in method, exceeds threshold &2' ).
set_check_message( '&1 executable statements in method reaching threshold of &2' ).
ENDMETHOD.


Expand Down
6 changes: 4 additions & 2 deletions src/checks/y_check_num_output_parameter.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ CLASS Y_CHECK_NUM_OUTPUT_PARAMETER IMPLEMENTATION.
settings-threshold = 2.
settings-documentation = |{ c_docs_path-checks }number-output-parameter.md|.

set_check_message( 'Too many output parameters!' ).
set_check_message( '&1 output parameters reaching threshold of &2' ).
ENDMETHOD.


Expand Down Expand Up @@ -67,7 +67,9 @@ CLASS Y_CHECK_NUM_OUTPUT_PARAMETER IMPLEMENTATION.
raise_error( statement_level = statement-level
statement_index = index
statement_from = statement-from + 1
error_priority = configuration-prio ).
error_priority = configuration-prio
parameter_01 = |{ outputs_of_statement }|
parameter_02 = |{ configuration-threshold }| ).

ENDMETHOD.

Expand Down
2 changes: 1 addition & 1 deletion src/checks/y_check_num_public_attributes.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ CLASS Y_CHECK_NUM_PUBLIC_ATTRIBUTES IMPLEMENTATION.
settings-threshold = 1.
settings-documentation = |{ c_docs_path-checks }number-public-attributes.md|.

set_check_message( '&1 public attributes. All attributes should be private by default.' ).
set_check_message( '&1 public attributes. All attributes should be private/protected by default.' ).
ENDMETHOD.


Expand Down
2 changes: 1 addition & 1 deletion src/checks/y_check_number_attributes.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ CLASS Y_CHECK_NUMBER_ATTRIBUTES IMPLEMENTATION.
settings-threshold = 12.
settings-documentation = |{ c_docs_path-checks }number-attributes.md|.

set_check_message( '&1 attributes, exceeding threshold &2' ).
set_check_message( '&1 attributes reaching threshold of &2' ).
ENDMETHOD.


Expand Down
2 changes: 1 addition & 1 deletion src/checks/y_check_number_events.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ CLASS Y_CHECK_NUMBER_EVENTS IMPLEMENTATION.
settings-pseudo_comment = '"#EC NUMBER_EVENTS' ##NO_TEXT.
settings-documentation = |{ c_docs_path-checks }number-events.md|.

set_check_message( 'There are &1 events, exceeding threshold of &2' ).
set_check_message( '&1 events reaching threshold of &2' ).
ENDMETHOD.


Expand Down
2 changes: 1 addition & 1 deletion src/checks/y_check_number_interfaces.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ CLASS Y_CHECK_NUMBER_INTERFACES IMPLEMENTATION.
settings-threshold = 4.
settings-documentation = |{ c_docs_path-checks }number-interfaces.md|.

set_check_message( 'There are &1 interfaces, exceeding threshold of &2' ).
set_check_message( '&1 interfaces reaching threshold of &2' ).
ENDMETHOD.


Expand Down
2 changes: 1 addition & 1 deletion src/checks/y_check_number_methods.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ CLASS Y_CHECK_NUMBER_METHODS IMPLEMENTATION.
settings-threshold = 20.
settings-documentation = |{ c_docs_path-checks }number-methods.md|.

set_check_message( '&1 methods, exceeding threshold of &2' ).
set_check_message( '&1 methods reaching threshold of &2' ).
ENDMETHOD.


Expand Down