Skip to content

clm: add --create-namespace to apply #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 10, 2024
Merged

clm: add --create-namespace to apply #184

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions clm/cmd/apply.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,10 @@ import (

"github.com/spf13/cobra"

corev1 "k8s.io/api/core/v1"
apierrors "k8s.io/apimachinery/pkg/api/errors"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
apitypes "k8s.io/apimachinery/pkg/types"
utilerrors "k8s.io/apimachinery/pkg/util/errors"

"github.com/sap/component-operator-runtime/clm/internal/backoff"
Expand All @@ -26,8 +29,9 @@ import (
const applyUsage = `Apply component manifests to Kubernetes cluster`

type applyOptions struct {
valuesSources []string
timeout time.Duration
valuesSources []string
createNamespace bool
timeout time.Duration
}

func newApplyCmd() *cobra.Command {
Expand Down Expand Up @@ -60,6 +64,14 @@ func newApplyCmd() *cobra.Command {

ownerId := fullName + "/" + namespace + "/" + name

if err := clnt.Get(context.TODO(), apitypes.NamespacedName{Name: namespace}, &corev1.Namespace{}); apierrors.IsNotFound(err) && options.createNamespace {
if err := clnt.Create(context.TODO(), &corev1.Namespace{ObjectMeta: metav1.ObjectMeta{Name: namespace}}); err != nil {
return err
}
} else if err != nil {
return err
}

release, err := releaseClient.Get(context.TODO(), namespace, name)
if err != nil {
if apierrors.IsNotFound(err) {
Expand Down Expand Up @@ -145,6 +157,7 @@ func newApplyCmd() *cobra.Command {

flags := cmd.Flags()
flags.StringArrayVarP(&options.valuesSources, "values", "f", nil, "Path to values file in yaml format (can be repeated, values will be merged in order of appearance)")
flags.BoolVar(&options.createNamespace, "create-namespace", false, "Create release namespace if not existing")
flags.DurationVar(&options.timeout, "timeout", 0, "Time to wait for the operation to complete (default is to wait forever)")

return cmd
Expand Down
Loading