Revert: pass external job_id and deployment_id #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ability to pass an external job_id and deployment_id never materialized in the Data Attribute Recommendation service. For this reason, this commit removes the corresponding functionality in the SDK. Closes #106
Contributor
Author
|
Coverage decreased because I deleted some tests. I am not sure I can do anything about that. |
karthikmswamy
approved these changes
Sep 17, 2021
Contributor
karthikmswamy
left a comment
karthikmswamy
left a comment
There was a problem hiding this comment.
Thanks! The removal of a test breaks the build?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ability to pass an external job_id and deployment_id never
materialized in the Data Attribute Recommendation service. For
this reason, this commit removes the corresponding functionality
in the SDK.
Closes #106