Skip to content

General resilience #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 17, 2022
Merged

General resilience #129

merged 2 commits into from
Jun 17, 2022
+6 −3

Conversation

@mhaas
Copy link
Contributor

@mhaas mhaas commented Jun 17, 2022

Checks:

  • README.md is maintained
  • Documentation is maintained
  • CHANGELOG.md is updated
  • Tests added

@mhaas
Improve resilience by tweaking retry configuration
f46845a 
With the previous settings of `backoff_factor = 0.03` and `NUM_REQUEST_RETRIES = 5`,
we would give the DAR service only around 5 seconds to recover.

By changing to `backoff_factor = 0.05` and ``NUM_REQUEST_RETRIES = 5`, we end
up retrying over a period of around 30s.
@mhaas mhaas requested a review from SreevishnuAB June 17, 2022 07:53
@mhaas mhaas changed the base branch from main to bulk_inference_resilience June 17, 2022 07:53
SreevishnuAB
SreevishnuAB approved these changes Jun 17, 2022
View reviewed changes
Copy link
Contributor

@SreevishnuAB SreevishnuAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Base automatically changed from bulk_inference_resilience to main June 17, 2022 15:55
@mhaas mhaas merged commit 07e05fe into main Jun 17, 2022
@mhaas mhaas deleted the general_resilience branch June 17, 2022 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@SreevishnuAB SreevishnuAB SreevishnuAB approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mhaas @SreevishnuAB