Skip to content

General resilience #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 17, 2022
Merged

General resilience #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f46845a
Improve resilience by tweaking retry configuration
mhaas Jun 17, 2022
16aa372
Merge branch 'main' into general_resilience
mhaas Jun 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
because the special error response object will have a value of `None` for the `labels` key.
As this project is still versioned below 1.0.0, the breaking API change does not warrant a major version update.
See [#128] for details.
* Improve reliability by tweaking retry configuration [#129]

[#128]: https://github.com/SAP/data-attribute-recommendation-python-sdk/pull/128
[#129]: https://github.com/SAP/data-attribute-recommendation-python-sdk/pull/129

## [0.11.0]

Expand Down Expand Up @@ -266,7 +268,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

* First public release

[Unreleased]: https://github.com/SAP/data-attribute-recommendation-python-sdk/compare/rel/0.10.0...HEAD
[Unreleased]: https://github.com/SAP/data-attribute-recommendation-python-sdk/compare/rel/0.12.0...HEAD
[0.11.0]: https://github.com/SAP/data-attribute-recommendation-python-sdk/compare/rel/0.11.0...rel/0.12.0
[0.11.0]: https://github.com/SAP/data-attribute-recommendation-python-sdk/compare/rel/0.10.0...rel/0.11.0
[0.10.0]: https://github.com/SAP/data-attribute-recommendation-python-sdk/compare/rel/0.9.2...rel/0.10.0
[0.9.2]: https://github.com/SAP/data-attribute-recommendation-python-sdk/compare/rel/0.9.1...rel/0.9.2
Expand Down
4 changes: 2 additions & 2 deletions sap/aibus/dar/client/util/http_transport.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

CONNECT_TIMEOUT = 240

NUM_REQUEST_RETRIES = 5 # total number of request retries
NUM_REQUEST_RETRIES = 7 # total number of request retries


class HttpMethodsProtocol(Protocol):
Expand Down Expand Up @@ -162,7 +162,7 @@ def __init__(
self,
num_retries: int,
session: Session = None,
backoff_factor: float = 0.03,
backoff_factor: float = 0.05,
status_forcelist: Tuple = (413, 429, 500, 502, 503, 504),
):
"""
Expand Down