Email notifications for broken builds on master #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvgenyArn
approved these changes
Jul 2, 2020
EvgenyArn
left a comment
EvgenyArn
left a comment
There was a problem hiding this comment.
Just wondering if I will start getting even more spam, as our emails are exposed to crawlers? :)
karthikmswamy
approved these changes
Jul 2, 2020
Contributor
karthikmswamy
left a comment
karthikmswamy
left a comment
There was a problem hiding this comment.
Thanks for adding this! Looks good.
Contributor
Author
|
@EvgenyArn I am sure SAP spam filters can handle it ;) Will obfuscate in separate commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge #18 first.
Given that we run system tests only on master, we should be sure to act on any problems. It is not as obvious as a failing PR. This commit adds email notifications for failed builds on master.