Document release process #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthikmswamy
approved these changes
Jul 3, 2020
Contributor
karthikmswamy
left a comment
karthikmswamy
left a comment
There was a problem hiding this comment.
Quick question: would anyone creating a release need accounts/permissions to push to pypi?
docs/source/release_process.rst
Outdated
| @@ -0,0 +1,45 @@ | |||
| Creating a new Release of the SDK | |||
Contributor
There was a problem hiding this comment.
Just a minor point: would this be more clear about which SDK - Creating a new release of the Data Attribute Recommendation Python SDK?
Contributor
There was a problem hiding this comment.
Also, I do not feel release needs to be capitalised, but this is just my opinion.
Contributor
|
By the way, this is really well documented and very useful / important information. Thanks for adding this :) |
Contributor
Author
|
Hi @karthikmswamy, thanks for the pointers. Does the latest update clarify your questions? |
karthikmswamy
approved these changes
Jul 3, 2020
Contributor
karthikmswamy
left a comment
karthikmswamy
left a comment
There was a problem hiding this comment.
Awesome! Thanks for adding this!
Contributor
Author
|
Fixes #22 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.