Skip to content

Conversation

@mhaas
Copy link
Contributor

@mhaas mhaas commented Aug 11, 2020

No description provided.

@mhaas mhaas requested a review from karthikmswamy August 11, 2020 09:31
Copy link
Contributor

@karthikmswamy karthikmswamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Should we add the line about API stability in the README file as well? Might make this more transparent and visible, don't you think?


Note that this project follows `Semantic Versioning`_. Versions
below `1.0.0` are not guaranteed to have a stable API. For this reason, please
pay attention to the `Changelog`_.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good idea. I'm, however, not sure how many people might read this here. Should we also add this to the README file in the first few lines to make this clear to anyone using the SDK?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I added it in the README above. Is that what you had in mind?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I see that this is actually sourced by the README file. Thanks!

@mhaas mhaas merged commit f90ab07 into master Aug 11, 2020
@mhaas mhaas deleted the chore/prepare_0_7_0 branch August 11, 2020 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants