Skip to content

added create-service-push plugin to image#10

Closed
Shanuson wants to merge 1 commit intoSAP:masterfrom
Shanuson:patch-1
Closed

added create-service-push plugin to image#10
Shanuson wants to merge 1 commit intoSAP:masterfrom
Shanuson:patch-1

Conversation

@Shanuson
Copy link
Copy Markdown

@Shanuson Shanuson commented Oct 1, 2019

This PR adds the Create-Service-Push plugin to the image.
Needed for a step CloudFoundryServiceCreate in SAP/jenkins-library#892

@Shanuson
Copy link
Copy Markdown
Author

Shanuson commented Oct 1, 2019

I'm not sure about your tests. Running a complete pipeline to test a docker image that makes use of it? They also don't work locally for me since I'm not part of a cf org piper. Seems like the test could fail for a lot of reasons unrelated to the docker image itself.

Also I can't fix the Travis Error:

$ chmod +x runTests.sh && ./runTests.sh
Failure: Variable CX_INFRA_IT_CF_USERNAME is unset

@fwilhe
Copy link
Copy Markdown
Contributor

fwilhe commented Oct 1, 2019

Hi @Shanuson

thanks for your contribution.

What you've encountered is a technical limitation of travis ci. We need credentials to test if this image can push an example app, and travis won't make this available in forked repos for security reasons. I've cherry picked your commit and pushed it to a upstream branch, see #11. As of now I'm not aware of any better way to do this, since we do need the credentials to meaningfully test the image.

We'll merge #11 if everything looks good.

Kind regards

Florian

@Shanuson
Copy link
Copy Markdown
Author

Shanuson commented Oct 1, 2019

After merge of #11 we can close this, thanks for the promt merge.

@Shanuson Shanuson closed this Oct 1, 2019
@Shanuson Shanuson deleted the patch-1 branch October 1, 2019 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants