added create-service-push plugin to image#10
added create-service-push plugin to image#10Shanuson wants to merge 1 commit intoSAP:masterfrom Shanuson:patch-1
Conversation
|
I'm not sure about your tests. Running a complete pipeline to test a docker image that makes use of it? They also don't work locally for me since I'm not part of a cf org piper. Seems like the test could fail for a lot of reasons unrelated to the docker image itself. Also I can't fix the Travis Error: $ chmod +x runTests.sh && ./runTests.sh
Failure: Variable CX_INFRA_IT_CF_USERNAME is unset |
|
Hi @Shanuson thanks for your contribution. What you've encountered is a technical limitation of travis ci. We need credentials to test if this image can push an example app, and travis won't make this available in forked repos for security reasons. I've cherry picked your commit and pushed it to a upstream branch, see #11. As of now I'm not aware of any better way to do this, since we do need the credentials to meaningfully test the image. We'll merge #11 if everything looks good. Kind regards Florian |
|
After merge of #11 we can close this, thanks for the promt merge. |
This PR adds the Create-Service-Push plugin to the image.
Needed for a step CloudFoundryServiceCreate in SAP/jenkins-library#892