update cf cli to version 7.2

[radsoulbeard]

• update mta plugin to 2.5.1
• remove create service plugin as contained in cf cli v7

fixes #31

[fwilhe]

Hi @radsoulbeard

are you sure this is not a breaking change for existing pipelines? I don't have the time to do an in depth review, and I'm not an active CF user (anymore), so I'm probably not the best reviewer here.

Looping in @marcusholl @CCFenner

Can you judge if this breaks anything?

[marcusholl]

Can you judge if this breaks anything?

No. Not close enough to cf use-cases. We should have test cases, I suppose ...

[radsoulbeard]

Hi @radsoulbeard

are you sure this is not a breaking change for existing pipelines? I don't have the time to do an in depth review, and I'm not an active CF user (anymore), so I'm probably not the best reviewer here.

Looping in @marcusholl @CCFenner

Can you judge if this breaks anything?

Creating a new image version does not mean to change the defaults in the Piper library immediately. The integration tests passed.

[marcusholl]

@radsoulbeard

does not mean to change the defaults in the Piper library immediately

Can you clarify that? As far as I can see we have configured ppiper/cf-cli here and some lines below. Since there is no explicit version we use latest, I suppose. That means if there is a new cf-cli docker image that-one will be used. Am I wrong?

Maybe we recommend to the customers to configure fixed versions, but by default there is no fixed version.

[radsoulbeard]

@marcusholl
You are right, that will pull latest. We need to test that carefully.

[radsoulbeard]

testResults.txt
I tested all additional steps with the new version. cloudFoundryCreateSpace, cloudFoundryCreateService, cloudFoundryCreateServiceKey, cloudFoundryDeleteService and cloudFoundryDeleteSpace still works.

[radsoulbeard]

As discussed, SAP/jenkins-library defaults are now on a dedicated tag v5
Temporary fix ppiper/cf-cli version SAP/jenkins-library#2541

[OliverNocon]

LGTM