Skip to content

Conversation

@jbadan
Copy link
Contributor

@jbadan jbadan commented May 12, 2020

Description

Add header/footer to storybook. Update colors to match design spec.

fixes #issueid

@netlify
Copy link

netlify bot commented May 12, 2020

Deploy preview for fundamental-react ready!

Built with commit 9775841

https://deploy-preview-1007--fundamental-react.netlify.app

@jbadan jbadan requested review from a team and estelaxu3 May 12, 2020 21:12
collapseDepth: 3
}
);
document.querySelectorAll('.toc-link').forEach( x => x.setAttribute('target','_self'));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ugly - can anyone think of another way to do this? It doesn't look like the tocbot api allows adding additional attributes.

It's also not updating the active class (blue left border) as you scroll

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@jbadan jbadan changed the title docs: add header and footer to storybook docs: add header, footer and toc to storybook May 12, 2020
Copy link
Contributor

@bcullman bcullman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@jbadan jbadan requested a review from a team May 14, 2020 13:29
Copy link
Contributor

@greg-a-smith greg-a-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 🚢

@jbadan jbadan merged commit 9d157d3 into master May 14, 2020
@jbadan jbadan deleted the headerfooter branch May 14, 2020 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants