-
Notifications
You must be signed in to change notification settings - Fork 78
docs: add header, footer and toc to storybook #1007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Deploy preview for fundamental-react ready! Built with commit 9775841 |
| collapseDepth: 3 | ||
| } | ||
| ); | ||
| document.querySelectorAll('.toc-link').forEach( x => x.setAttribute('target','_self')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is ugly - can anyone think of another way to do this? It doesn't look like the tocbot api allows adding additional attributes.
It's also not updating the active class (blue left border) as you scroll
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
bcullman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
greg-a-smith
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. 🚢
Description
Add header/footer to storybook. Update colors to match design spec.
fixes #issueid