fix: Username is cut off from Shellbar #1008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Deploy preview for fundamental-react ready! Built with commit 8bbbb35 |
dmatis
changed the title
jbadan
requested changes
May 12, 2020
Contributor
There was a problem hiding this comment.
Can you remove all the _playground files that are accidentally getting checked in?
you'll also need to run npm run test:storybook:update
https://github.com/SAP/fundamental-react/wiki/Testing#npm-run-teststorybookupdate
added 2 commits
May 12, 2020 15:13
dmatis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where the Username is cut off from Shellbar (#1002)
PopoverandShellbarstories were missing an export in order to appear in the docsProductMenuwas missing an array and causing errors in StorybookPopoverstoryshot containing React hook