feat: width adjustments for popover based components, class changes, MultiInput changes #1016
+72
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for fundamental-react ready! Built with commit 3f66266 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
widthSizingTypefor popover-based components, mainly to account for the max 37.5rem width for listfd-list--dropdownclass to ComboboxInputfd-input-group__inputclass incorrectly applied to child div tokenizer in MultiInput, instead applied manually toinputMultiInput many options
Before
After
MultiInput long options
Before
After
Select
Before
After
Known Issues
widthSizingType, which causes the width to be 'one step behind' when selecting/deselecting items.