feat: update fundamental-styles to 0.10.0-rc.1 #1025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for fundamental-react ready! Built with commit 3aa8be9 |
jbadan
requested changes
May 21, 2020
Contributor
jbadan
left a comment
jbadan
left a comment
There was a problem hiding this comment.
This is an amazing update!!!! 🎉 🎉
Really small mostly nitpicky changes - feel free to dismiss and make an issue instead.
| "chain-function": "^1.0.1", | ||
| "classnames": "^2.2.6", | ||
| "fundamental-styles": "0.8.2-rc.0", | ||
| "fundamental-styles": "0.10.0-rc.1", |
| export const primary = () => (<Avatar glyph='cart' size='m' />); | ||
|
|
||
| export const sizes = () => ( | ||
| <div className='fr-container'> |
Contributor
There was a problem hiding this comment.
This got changed out from underneath you - but this class is now fddocs-container - that will get you the spacing you want.
jbadan
approved these changes
May 21, 2020
Contributor
jbadan
left a comment
jbadan
left a comment
There was a problem hiding this comment.
LGTM 🚢
We recently updated standard version so you should be able to include
BREAKING CHANGE: first breaking change
* more changes
prsdthkr
approved these changes
May 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Listupdated to include partial navigation, full navigation, action items, selection, and bylinesIdentifierupdated to include more states and renamed toAvatarTimecomplete refactorSideNavigationmarkup updatedfundamental-stylesSee changelog for full updates: https://github.com/SAP/fundamental-styles/blob/master/CHANGELOG.md
fixes #1029
fixes #1027
fixes #1028
fixes #1038