Issue#121: refactor search input #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Tests will be added in a separate ticket |
Contributor
|
@InnaAtanasova - A couple of questions on the new implementation of the control.
|
Contributor
Author
@chrismanciero , this is a good question. So far there are no clear guidelines about the behaviour of the components. We can put back in this functionality. It makes sense to have it. |
Contributor
Author
If the user doesn't specify |
Contributor
Author
@chrismanciero , this is also a valid point. My idea of attaching a callback property to each item and a separate method to handle the Enter key is to give more freedom to the developers and make the component more generic. But I get your point. I will raise the question to the Fiori Fundamentals team and we can discuss it after the holidays. |
Contributor
Author
|
@chrismanciero , thanks for the review and for the valid points! |
droshev
added a commit
that referenced
this pull request
Jan 3, 2019
* fix: eject from create react app; prep for linting (#107) * eject from create react app; prep for linting * remove babel config from package.json * fix: cleanup package (#116) * sort deps * remove npm warning about missing repostory field * remove dupe jest dep warning * fix: init linting (#106) * init lint; comment out failing lints * eslint fix: comma-dangle * eslint fix: comma-spacing * eslint fix: comma-style * eslint fix: dot-notation * eslint fix: eol-last * eslint fix: keyword-spacing * eslint fix: jsx-quotes * eslint fix: no-multi-spaces * eslint fix: no-trailing-spaces * eslint fix: quote-props * eslint fix: semi * eslint fix: space-before-blocks * eslint fix: semi-spacing * eslint fix: space-infix-ops * eslint fix: space-before-function-paren * eslint fix: react/sort-prop-types * eslint fix: react/self-closing-comp * eslint fix: react/prop-types * eslint fix: react/jsx-tag-spacing * eslint fix: react/jsx-max-props-per-line * eslint fix: react/jsx-indent-props * eslint fix: react/jsx-indent * eslint fix: react/jsx-equals-spacing * eslint fix: react/jsx-closing-bracket-location * eslint fix: react/jsx-boolean-value * eslint fix: quotes * eslint fix: loosely-restrict-imports/loosely-restrict-imports * fix: Add Polyfill for IE11 support (#117) * IE11 Polyfill for babel * Removing Object.includes from Datepicker * fix package.json sort * fix: init coverage (#119) * add helper package.json scripts * emit coverage for travis run * add build for fix branches * fix: move lint extend react-app to eslintrc. comment out due to failing rules (#118) * more lint extend react-app to eslintrc. comment out due to failing rules * remove test scripts * adds additional class that adds space between the components, remove navbar component (#120) * Issue#121: refactor search input (#122) * Issue#90: adds shellbar component implementation, popover refactoring (#123) * Issue#90: adds shellbar component implementation, popover refactoring * Issue#90: failing test for popover * Update README.md * Adds a button that shows/hides the example code snippets (#127) * Update webpack dev server (#131) * update webpack-dev-server to 3.1.14 * update * fix failing unit test * Feature/issue#93 spreading props (#129) * Issue#93: adds className and spread props for Button and ActionBar * Issue#93: adds className and spread props for Alert and Status Indicators * Issue#93: adds className and spread props for Breadcrumb and Calendar * Issue#93: fix broken tests * Issue#93: adds className and spread props Combobox, DatePicker and Dropdown * Issue#93: adds className and spread props for Forms * Issue#93: adds className and spread props for Icon, Identifier and Image * Issue#93: adds className and spread props for the rest of the components * Issue#93: adds ...props for the Popover, Search Input and Tabs * Issue#93: adds omitted ...props for the Calendar, adds new snapshots for Dropdown and Popover after adding ...props * Update unit tests (#132) * update unit tests * updated test cases for className, init test for ShellBar * fixes the broken Show Code btn functionality * Update README.md * Adds icons and notification count in the dropdown menu when items col… (#128) * Adds icons and notification count in the dropdown menu when items collapse * fixes failing tests and build * deals with some console warnings realted to passing the props from Date Picker to Calendar * #130 fix the library build (#133) * Implement a "copy" button in the playground code snippets (#135) * 📚 issue #124 add copy button for documentation code * 📚 issue #124 center button * 📚 issue #124 fix css error
droshev
added a commit
that referenced
this pull request
Jan 4, 2019
* fix: eject from create react app; prep for linting (#107) * eject from create react app; prep for linting * remove babel config from package.json * fix: cleanup package (#116) * sort deps * remove npm warning about missing repostory field * remove dupe jest dep warning * fix: init linting (#106) * init lint; comment out failing lints * eslint fix: comma-dangle * eslint fix: comma-spacing * eslint fix: comma-style * eslint fix: dot-notation * eslint fix: eol-last * eslint fix: keyword-spacing * eslint fix: jsx-quotes * eslint fix: no-multi-spaces * eslint fix: no-trailing-spaces * eslint fix: quote-props * eslint fix: semi * eslint fix: space-before-blocks * eslint fix: semi-spacing * eslint fix: space-infix-ops * eslint fix: space-before-function-paren * eslint fix: react/sort-prop-types * eslint fix: react/self-closing-comp * eslint fix: react/prop-types * eslint fix: react/jsx-tag-spacing * eslint fix: react/jsx-max-props-per-line * eslint fix: react/jsx-indent-props * eslint fix: react/jsx-indent * eslint fix: react/jsx-equals-spacing * eslint fix: react/jsx-closing-bracket-location * eslint fix: react/jsx-boolean-value * eslint fix: quotes * eslint fix: loosely-restrict-imports/loosely-restrict-imports * fix: Add Polyfill for IE11 support (#117) * IE11 Polyfill for babel * Removing Object.includes from Datepicker * fix package.json sort * fix: init coverage (#119) * add helper package.json scripts * emit coverage for travis run * add build for fix branches * fix: move lint extend react-app to eslintrc. comment out due to failing rules (#118) * more lint extend react-app to eslintrc. comment out due to failing rules * remove test scripts * adds additional class that adds space between the components, remove navbar component (#120) * Issue#121: refactor search input (#122) * Issue#90: adds shellbar component implementation, popover refactoring (#123) * Issue#90: adds shellbar component implementation, popover refactoring * Issue#90: failing test for popover * Update README.md * Adds a button that shows/hides the example code snippets (#127) * Update webpack dev server (#131) * update webpack-dev-server to 3.1.14 * update * fix failing unit test * Feature/issue#93 spreading props (#129) * Issue#93: adds className and spread props for Button and ActionBar * Issue#93: adds className and spread props for Alert and Status Indicators * Issue#93: adds className and spread props for Breadcrumb and Calendar * Issue#93: fix broken tests * Issue#93: adds className and spread props Combobox, DatePicker and Dropdown * Issue#93: adds className and spread props for Forms * Issue#93: adds className and spread props for Icon, Identifier and Image * Issue#93: adds className and spread props for the rest of the components * Issue#93: adds ...props for the Popover, Search Input and Tabs * Issue#93: adds omitted ...props for the Calendar, adds new snapshots for Dropdown and Popover after adding ...props * Update unit tests (#132) * update unit tests * updated test cases for className, init test for ShellBar * fixes the broken Show Code btn functionality * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Adds icons and notification count in the dropdown menu when items col… (#128) * Adds icons and notification count in the dropdown menu when items collapse * fixes failing tests and build * deals with some console warnings realted to passing the props from Date Picker to Calendar * #130 fix the library build (#133) * Implement a "copy" button in the playground code snippets (#135) * 📚 issue #124 add copy button for documentation code * 📚 issue #124 center button * 📚 issue #124 fix css error * #137 downgrade the version of webpack-dev-server to 3.19 as react-script@2.1.2 depends on that version (#138) * FOR DISCUSSION - Enhancement/improvements for search input component (#136) * adds onChange props, option to hide the search btn and compact mode for Search Input component * adds new snapshot for the search input test * adds an example with custom onChange func * automate versioning and publish via travis (#140)
droshev
added a commit
that referenced
this pull request
Jan 4, 2019
* fix: eject from create react app; prep for linting (#107) * eject from create react app; prep for linting * remove babel config from package.json * fix: cleanup package (#116) * sort deps * remove npm warning about missing repostory field * remove dupe jest dep warning * fix: init linting (#106) * init lint; comment out failing lints * eslint fix: comma-dangle * eslint fix: comma-spacing * eslint fix: comma-style * eslint fix: dot-notation * eslint fix: eol-last * eslint fix: keyword-spacing * eslint fix: jsx-quotes * eslint fix: no-multi-spaces * eslint fix: no-trailing-spaces * eslint fix: quote-props * eslint fix: semi * eslint fix: space-before-blocks * eslint fix: semi-spacing * eslint fix: space-infix-ops * eslint fix: space-before-function-paren * eslint fix: react/sort-prop-types * eslint fix: react/self-closing-comp * eslint fix: react/prop-types * eslint fix: react/jsx-tag-spacing * eslint fix: react/jsx-max-props-per-line * eslint fix: react/jsx-indent-props * eslint fix: react/jsx-indent * eslint fix: react/jsx-equals-spacing * eslint fix: react/jsx-closing-bracket-location * eslint fix: react/jsx-boolean-value * eslint fix: quotes * eslint fix: loosely-restrict-imports/loosely-restrict-imports * fix: Add Polyfill for IE11 support (#117) * IE11 Polyfill for babel * Removing Object.includes from Datepicker * fix package.json sort * fix: init coverage (#119) * add helper package.json scripts * emit coverage for travis run * add build for fix branches * fix: move lint extend react-app to eslintrc. comment out due to failing rules (#118) * more lint extend react-app to eslintrc. comment out due to failing rules * remove test scripts * adds additional class that adds space between the components, remove navbar component (#120) * Issue#121: refactor search input (#122) * Issue#90: adds shellbar component implementation, popover refactoring (#123) * Issue#90: adds shellbar component implementation, popover refactoring * Issue#90: failing test for popover * Update README.md * Adds a button that shows/hides the example code snippets (#127) * Update webpack dev server (#131) * update webpack-dev-server to 3.1.14 * update * fix failing unit test * Feature/issue#93 spreading props (#129) * Issue#93: adds className and spread props for Button and ActionBar * Issue#93: adds className and spread props for Alert and Status Indicators * Issue#93: adds className and spread props for Breadcrumb and Calendar * Issue#93: fix broken tests * Issue#93: adds className and spread props Combobox, DatePicker and Dropdown * Issue#93: adds className and spread props for Forms * Issue#93: adds className and spread props for Icon, Identifier and Image * Issue#93: adds className and spread props for the rest of the components * Issue#93: adds ...props for the Popover, Search Input and Tabs * Issue#93: adds omitted ...props for the Calendar, adds new snapshots for Dropdown and Popover after adding ...props * Update unit tests (#132) * update unit tests * updated test cases for className, init test for ShellBar * fixes the broken Show Code btn functionality * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Adds icons and notification count in the dropdown menu when items col… (#128) * Adds icons and notification count in the dropdown menu when items collapse * fixes failing tests and build * deals with some console warnings realted to passing the props from Date Picker to Calendar * #130 fix the library build (#133) * Implement a "copy" button in the playground code snippets (#135) * 📚 issue #124 add copy button for documentation code * 📚 issue #124 center button * 📚 issue #124 fix css error * #137 downgrade the version of webpack-dev-server to 3.19 as react-script@2.1.2 depends on that version (#138) * FOR DISCUSSION - Enhancement/improvements for search input component (#136) * adds onChange props, option to hide the search btn and compact mode for Search Input component * adds new snapshot for the search input test * adds an example with custom onChange func * automate versioning and publish via travis (#140)
droshev
added a commit
that referenced
this pull request
Jan 4, 2019
* fix: eject from create react app; prep for linting (#107) * eject from create react app; prep for linting * remove babel config from package.json * fix: cleanup package (#116) * sort deps * remove npm warning about missing repostory field * remove dupe jest dep warning * fix: init linting (#106) * init lint; comment out failing lints * eslint fix: comma-dangle * eslint fix: comma-spacing * eslint fix: comma-style * eslint fix: dot-notation * eslint fix: eol-last * eslint fix: keyword-spacing * eslint fix: jsx-quotes * eslint fix: no-multi-spaces * eslint fix: no-trailing-spaces * eslint fix: quote-props * eslint fix: semi * eslint fix: space-before-blocks * eslint fix: semi-spacing * eslint fix: space-infix-ops * eslint fix: space-before-function-paren * eslint fix: react/sort-prop-types * eslint fix: react/self-closing-comp * eslint fix: react/prop-types * eslint fix: react/jsx-tag-spacing * eslint fix: react/jsx-max-props-per-line * eslint fix: react/jsx-indent-props * eslint fix: react/jsx-indent * eslint fix: react/jsx-equals-spacing * eslint fix: react/jsx-closing-bracket-location * eslint fix: react/jsx-boolean-value * eslint fix: quotes * eslint fix: loosely-restrict-imports/loosely-restrict-imports * fix: Add Polyfill for IE11 support (#117) * IE11 Polyfill for babel * Removing Object.includes from Datepicker * fix package.json sort * fix: init coverage (#119) * add helper package.json scripts * emit coverage for travis run * add build for fix branches * fix: move lint extend react-app to eslintrc. comment out due to failing rules (#118) * more lint extend react-app to eslintrc. comment out due to failing rules * remove test scripts * adds additional class that adds space between the components, remove navbar component (#120) * Issue#121: refactor search input (#122) * Issue#90: adds shellbar component implementation, popover refactoring (#123) * Issue#90: adds shellbar component implementation, popover refactoring * Issue#90: failing test for popover * Update README.md * Adds a button that shows/hides the example code snippets (#127) * Update webpack dev server (#131) * update webpack-dev-server to 3.1.14 * update * fix failing unit test * Feature/issue#93 spreading props (#129) * Issue#93: adds className and spread props for Button and ActionBar * Issue#93: adds className and spread props for Alert and Status Indicators * Issue#93: adds className and spread props for Breadcrumb and Calendar * Issue#93: fix broken tests * Issue#93: adds className and spread props Combobox, DatePicker and Dropdown * Issue#93: adds className and spread props for Forms * Issue#93: adds className and spread props for Icon, Identifier and Image * Issue#93: adds className and spread props for the rest of the components * Issue#93: adds ...props for the Popover, Search Input and Tabs * Issue#93: adds omitted ...props for the Calendar, adds new snapshots for Dropdown and Popover after adding ...props * Update unit tests (#132) * update unit tests * updated test cases for className, init test for ShellBar * fixes the broken Show Code btn functionality * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Adds icons and notification count in the dropdown menu when items col… (#128) * Adds icons and notification count in the dropdown menu when items collapse * fixes failing tests and build * deals with some console warnings realted to passing the props from Date Picker to Calendar * #130 fix the library build (#133) * Implement a "copy" button in the playground code snippets (#135) * 📚 issue #124 add copy button for documentation code * 📚 issue #124 center button * 📚 issue #124 fix css error * #137 downgrade the version of webpack-dev-server to 3.19 as react-script@2.1.2 depends on that version (#138) * FOR DISCUSSION - Enhancement/improvements for search input component (#136) * adds onChange props, option to hide the search btn and compact mode for Search Input component * adds new snapshot for the search input test * adds an example with custom onChange func * automate versioning and publish via travis (#140) * remove limiting branches (#144)
jbadan
pushed a commit
that referenced
this pull request
Jan 4, 2019
* fix: eject from create react app; prep for linting (#107) * eject from create react app; prep for linting * remove babel config from package.json * fix: cleanup package (#116) * sort deps * remove npm warning about missing repostory field * remove dupe jest dep warning * fix: init linting (#106) * init lint; comment out failing lints * eslint fix: comma-dangle * eslint fix: comma-spacing * eslint fix: comma-style * eslint fix: dot-notation * eslint fix: eol-last * eslint fix: keyword-spacing * eslint fix: jsx-quotes * eslint fix: no-multi-spaces * eslint fix: no-trailing-spaces * eslint fix: quote-props * eslint fix: semi * eslint fix: space-before-blocks * eslint fix: semi-spacing * eslint fix: space-infix-ops * eslint fix: space-before-function-paren * eslint fix: react/sort-prop-types * eslint fix: react/self-closing-comp * eslint fix: react/prop-types * eslint fix: react/jsx-tag-spacing * eslint fix: react/jsx-max-props-per-line * eslint fix: react/jsx-indent-props * eslint fix: react/jsx-indent * eslint fix: react/jsx-equals-spacing * eslint fix: react/jsx-closing-bracket-location * eslint fix: react/jsx-boolean-value * eslint fix: quotes * eslint fix: loosely-restrict-imports/loosely-restrict-imports * fix: Add Polyfill for IE11 support (#117) * IE11 Polyfill for babel * Removing Object.includes from Datepicker * fix package.json sort * fix: init coverage (#119) * add helper package.json scripts * emit coverage for travis run * add build for fix branches * fix: move lint extend react-app to eslintrc. comment out due to failing rules (#118) * more lint extend react-app to eslintrc. comment out due to failing rules * remove test scripts * adds additional class that adds space between the components, remove navbar component (#120) * Issue#121: refactor search input (#122) * Issue#90: adds shellbar component implementation, popover refactoring (#123) * Issue#90: adds shellbar component implementation, popover refactoring * Issue#90: failing test for popover * Update README.md * Adds a button that shows/hides the example code snippets (#127) * Update webpack dev server (#131) * update webpack-dev-server to 3.1.14 * update * fix failing unit test * Feature/issue#93 spreading props (#129) * Issue#93: adds className and spread props for Button and ActionBar * Issue#93: adds className and spread props for Alert and Status Indicators * Issue#93: adds className and spread props for Breadcrumb and Calendar * Issue#93: fix broken tests * Issue#93: adds className and spread props Combobox, DatePicker and Dropdown * Issue#93: adds className and spread props for Forms * Issue#93: adds className and spread props for Icon, Identifier and Image * Issue#93: adds className and spread props for the rest of the components * Issue#93: adds ...props for the Popover, Search Input and Tabs * Issue#93: adds omitted ...props for the Calendar, adds new snapshots for Dropdown and Popover after adding ...props * Update unit tests (#132) * update unit tests * updated test cases for className, init test for ShellBar * fixes the broken Show Code btn functionality * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Adds icons and notification count in the dropdown menu when items col… (#128) * Adds icons and notification count in the dropdown menu when items collapse * fixes failing tests and build * deals with some console warnings realted to passing the props from Date Picker to Calendar * #130 fix the library build (#133) * Implement a "copy" button in the playground code snippets (#135) * 📚 issue #124 add copy button for documentation code * 📚 issue #124 center button * 📚 issue #124 fix css error * #137 downgrade the version of webpack-dev-server to 3.19 as react-script@2.1.2 depends on that version (#138) * FOR DISCUSSION - Enhancement/improvements for search input component (#136) * adds onChange props, option to hide the search btn and compact mode for Search Input component * adds new snapshot for the search input test * adds an example with custom onChange func * automate versioning and publish via travis (#140) * remove limiting branches (#144) * chore: merge master into develop [ci skip] * remove beta (#146)
jbadan
pushed a commit
that referenced
this pull request
Jan 4, 2019
* fix: eject from create react app; prep for linting (#107) * eject from create react app; prep for linting * remove babel config from package.json * fix: cleanup package (#116) * sort deps * remove npm warning about missing repostory field * remove dupe jest dep warning * fix: init linting (#106) * init lint; comment out failing lints * eslint fix: comma-dangle * eslint fix: comma-spacing * eslint fix: comma-style * eslint fix: dot-notation * eslint fix: eol-last * eslint fix: keyword-spacing * eslint fix: jsx-quotes * eslint fix: no-multi-spaces * eslint fix: no-trailing-spaces * eslint fix: quote-props * eslint fix: semi * eslint fix: space-before-blocks * eslint fix: semi-spacing * eslint fix: space-infix-ops * eslint fix: space-before-function-paren * eslint fix: react/sort-prop-types * eslint fix: react/self-closing-comp * eslint fix: react/prop-types * eslint fix: react/jsx-tag-spacing * eslint fix: react/jsx-max-props-per-line * eslint fix: react/jsx-indent-props * eslint fix: react/jsx-indent * eslint fix: react/jsx-equals-spacing * eslint fix: react/jsx-closing-bracket-location * eslint fix: react/jsx-boolean-value * eslint fix: quotes * eslint fix: loosely-restrict-imports/loosely-restrict-imports * fix: Add Polyfill for IE11 support (#117) * IE11 Polyfill for babel * Removing Object.includes from Datepicker * fix package.json sort * fix: init coverage (#119) * add helper package.json scripts * emit coverage for travis run * add build for fix branches * fix: move lint extend react-app to eslintrc. comment out due to failing rules (#118) * more lint extend react-app to eslintrc. comment out due to failing rules * remove test scripts * adds additional class that adds space between the components, remove navbar component (#120) * Issue#121: refactor search input (#122) * Issue#90: adds shellbar component implementation, popover refactoring (#123) * Issue#90: adds shellbar component implementation, popover refactoring * Issue#90: failing test for popover * Update README.md * Adds a button that shows/hides the example code snippets (#127) * Update webpack dev server (#131) * update webpack-dev-server to 3.1.14 * update * fix failing unit test * Feature/issue#93 spreading props (#129) * Issue#93: adds className and spread props for Button and ActionBar * Issue#93: adds className and spread props for Alert and Status Indicators * Issue#93: adds className and spread props for Breadcrumb and Calendar * Issue#93: fix broken tests * Issue#93: adds className and spread props Combobox, DatePicker and Dropdown * Issue#93: adds className and spread props for Forms * Issue#93: adds className and spread props for Icon, Identifier and Image * Issue#93: adds className and spread props for the rest of the components * Issue#93: adds ...props for the Popover, Search Input and Tabs * Issue#93: adds omitted ...props for the Calendar, adds new snapshots for Dropdown and Popover after adding ...props * Update unit tests (#132) * update unit tests * updated test cases for className, init test for ShellBar * fixes the broken Show Code btn functionality * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Adds icons and notification count in the dropdown menu when items col… (#128) * Adds icons and notification count in the dropdown menu when items collapse * fixes failing tests and build * deals with some console warnings realted to passing the props from Date Picker to Calendar * #130 fix the library build (#133) * Implement a "copy" button in the playground code snippets (#135) * 📚 issue #124 add copy button for documentation code * 📚 issue #124 center button * 📚 issue #124 fix css error * #137 downgrade the version of webpack-dev-server to 3.19 as react-script@2.1.2 depends on that version (#138) * FOR DISCUSSION - Enhancement/improvements for search input component (#136) * adds onChange props, option to hide the search btn and compact mode for Search Input component * adds new snapshot for the search input test * adds an example with custom onChange func * automate versioning and publish via travis (#140) * remove limiting branches (#144) * chore: merge master into develop [ci skip] * remove beta (#146) * switch travis to fundamental-bot (#148) * Update README.md * Update README.md * Update README.md * fix: move deploy to jobs (#149) * move deploy to build * trigger build
jbadan
added a commit
that referenced
this pull request
Jan 4, 2019
* fix: eject from create react app; prep for linting (#107) * eject from create react app; prep for linting * remove babel config from package.json * fix: cleanup package (#116) * sort deps * remove npm warning about missing repostory field * remove dupe jest dep warning * fix: init linting (#106) * init lint; comment out failing lints * eslint fix: comma-dangle * eslint fix: comma-spacing * eslint fix: comma-style * eslint fix: dot-notation * eslint fix: eol-last * eslint fix: keyword-spacing * eslint fix: jsx-quotes * eslint fix: no-multi-spaces * eslint fix: no-trailing-spaces * eslint fix: quote-props * eslint fix: semi * eslint fix: space-before-blocks * eslint fix: semi-spacing * eslint fix: space-infix-ops * eslint fix: space-before-function-paren * eslint fix: react/sort-prop-types * eslint fix: react/self-closing-comp * eslint fix: react/prop-types * eslint fix: react/jsx-tag-spacing * eslint fix: react/jsx-max-props-per-line * eslint fix: react/jsx-indent-props * eslint fix: react/jsx-indent * eslint fix: react/jsx-equals-spacing * eslint fix: react/jsx-closing-bracket-location * eslint fix: react/jsx-boolean-value * eslint fix: quotes * eslint fix: loosely-restrict-imports/loosely-restrict-imports * fix: Add Polyfill for IE11 support (#117) * IE11 Polyfill for babel * Removing Object.includes from Datepicker * fix package.json sort * fix: init coverage (#119) * add helper package.json scripts * emit coverage for travis run * add build for fix branches * fix: move lint extend react-app to eslintrc. comment out due to failing rules (#118) * more lint extend react-app to eslintrc. comment out due to failing rules * remove test scripts * adds additional class that adds space between the components, remove navbar component (#120) * Issue#121: refactor search input (#122) * Issue#90: adds shellbar component implementation, popover refactoring (#123) * Issue#90: adds shellbar component implementation, popover refactoring * Issue#90: failing test for popover * Update README.md * Adds a button that shows/hides the example code snippets (#127) * Update webpack dev server (#131) * update webpack-dev-server to 3.1.14 * update * fix failing unit test * Feature/issue#93 spreading props (#129) * Issue#93: adds className and spread props for Button and ActionBar * Issue#93: adds className and spread props for Alert and Status Indicators * Issue#93: adds className and spread props for Breadcrumb and Calendar * Issue#93: fix broken tests * Issue#93: adds className and spread props Combobox, DatePicker and Dropdown * Issue#93: adds className and spread props for Forms * Issue#93: adds className and spread props for Icon, Identifier and Image * Issue#93: adds className and spread props for the rest of the components * Issue#93: adds ...props for the Popover, Search Input and Tabs * Issue#93: adds omitted ...props for the Calendar, adds new snapshots for Dropdown and Popover after adding ...props * Update unit tests (#132) * update unit tests * updated test cases for className, init test for ShellBar * fixes the broken Show Code btn functionality * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Adds icons and notification count in the dropdown menu when items col… (#128) * Adds icons and notification count in the dropdown menu when items collapse * fixes failing tests and build * deals with some console warnings realted to passing the props from Date Picker to Calendar * #130 fix the library build (#133) * Implement a "copy" button in the playground code snippets (#135) * 📚 issue #124 add copy button for documentation code * 📚 issue #124 center button * 📚 issue #124 fix css error * #137 downgrade the version of webpack-dev-server to 3.19 as react-script@2.1.2 depends on that version (#138) * FOR DISCUSSION - Enhancement/improvements for search input component (#136) * adds onChange props, option to hide the search btn and compact mode for Search Input component * adds new snapshot for the search input test * adds an example with custom onChange func * automate versioning and publish via travis (#140) * remove limiting branches (#144) * chore: merge master into develop [ci skip] * remove beta (#146) * switch travis to fundamental-bot (#148) * Update README.md * Update README.md * Update README.md * fix: move deploy to jobs (#149) * move deploy to build * trigger build
jbadan
added a commit
that referenced
this pull request
Jan 4, 2019
* fix: eject from create react app; prep for linting (#107) * eject from create react app; prep for linting * remove babel config from package.json * fix: cleanup package (#116) * sort deps * remove npm warning about missing repostory field * remove dupe jest dep warning * fix: init linting (#106) * init lint; comment out failing lints * eslint fix: comma-dangle * eslint fix: comma-spacing * eslint fix: comma-style * eslint fix: dot-notation * eslint fix: eol-last * eslint fix: keyword-spacing * eslint fix: jsx-quotes * eslint fix: no-multi-spaces * eslint fix: no-trailing-spaces * eslint fix: quote-props * eslint fix: semi * eslint fix: space-before-blocks * eslint fix: semi-spacing * eslint fix: space-infix-ops * eslint fix: space-before-function-paren * eslint fix: react/sort-prop-types * eslint fix: react/self-closing-comp * eslint fix: react/prop-types * eslint fix: react/jsx-tag-spacing * eslint fix: react/jsx-max-props-per-line * eslint fix: react/jsx-indent-props * eslint fix: react/jsx-indent * eslint fix: react/jsx-equals-spacing * eslint fix: react/jsx-closing-bracket-location * eslint fix: react/jsx-boolean-value * eslint fix: quotes * eslint fix: loosely-restrict-imports/loosely-restrict-imports * fix: Add Polyfill for IE11 support (#117) * IE11 Polyfill for babel * Removing Object.includes from Datepicker * fix package.json sort * fix: init coverage (#119) * add helper package.json scripts * emit coverage for travis run * add build for fix branches * fix: move lint extend react-app to eslintrc. comment out due to failing rules (#118) * more lint extend react-app to eslintrc. comment out due to failing rules * remove test scripts * adds additional class that adds space between the components, remove navbar component (#120) * Issue#121: refactor search input (#122) * Issue#90: adds shellbar component implementation, popover refactoring (#123) * Issue#90: adds shellbar component implementation, popover refactoring * Issue#90: failing test for popover * Update README.md * Adds a button that shows/hides the example code snippets (#127) * Update webpack dev server (#131) * update webpack-dev-server to 3.1.14 * update * fix failing unit test * Feature/issue#93 spreading props (#129) * Issue#93: adds className and spread props for Button and ActionBar * Issue#93: adds className and spread props for Alert and Status Indicators * Issue#93: adds className and spread props for Breadcrumb and Calendar * Issue#93: fix broken tests * Issue#93: adds className and spread props Combobox, DatePicker and Dropdown * Issue#93: adds className and spread props for Forms * Issue#93: adds className and spread props for Icon, Identifier and Image * Issue#93: adds className and spread props for the rest of the components * Issue#93: adds ...props for the Popover, Search Input and Tabs * Issue#93: adds omitted ...props for the Calendar, adds new snapshots for Dropdown and Popover after adding ...props * Update unit tests (#132) * update unit tests * updated test cases for className, init test for ShellBar * fixes the broken Show Code btn functionality * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Adds icons and notification count in the dropdown menu when items col… (#128) * Adds icons and notification count in the dropdown menu when items collapse * fixes failing tests and build * deals with some console warnings realted to passing the props from Date Picker to Calendar * #130 fix the library build (#133) * Implement a "copy" button in the playground code snippets (#135) * 📚 issue #124 add copy button for documentation code * 📚 issue #124 center button * 📚 issue #124 fix css error * #137 downgrade the version of webpack-dev-server to 3.19 as react-script@2.1.2 depends on that version (#138) * FOR DISCUSSION - Enhancement/improvements for search input component (#136) * adds onChange props, option to hide the search btn and compact mode for Search Input component * adds new snapshot for the search input test * adds an example with custom onChange func * automate versioning and publish via travis (#140) * remove limiting branches (#144) * chore: merge master into develop [ci skip] * remove beta (#146) * switch travis to fundamental-bot (#148) * Update README.md * Update README.md * Update README.md * fix: move deploy to jobs (#149) * move deploy to build * trigger build * chore: merge master into develop [ci skip] * fix: add standard-version to package.json (#153) * remove pull request limitation * add standard version to package.json * fix: add pack PR limiter (#155)
jbadan
added a commit
that referenced
this pull request
Jan 4, 2019
* fix: eject from create react app; prep for linting (#107) * eject from create react app; prep for linting * remove babel config from package.json * fix: cleanup package (#116) * sort deps * remove npm warning about missing repostory field * remove dupe jest dep warning * fix: init linting (#106) * init lint; comment out failing lints * eslint fix: comma-dangle * eslint fix: comma-spacing * eslint fix: comma-style * eslint fix: dot-notation * eslint fix: eol-last * eslint fix: keyword-spacing * eslint fix: jsx-quotes * eslint fix: no-multi-spaces * eslint fix: no-trailing-spaces * eslint fix: quote-props * eslint fix: semi * eslint fix: space-before-blocks * eslint fix: semi-spacing * eslint fix: space-infix-ops * eslint fix: space-before-function-paren * eslint fix: react/sort-prop-types * eslint fix: react/self-closing-comp * eslint fix: react/prop-types * eslint fix: react/jsx-tag-spacing * eslint fix: react/jsx-max-props-per-line * eslint fix: react/jsx-indent-props * eslint fix: react/jsx-indent * eslint fix: react/jsx-equals-spacing * eslint fix: react/jsx-closing-bracket-location * eslint fix: react/jsx-boolean-value * eslint fix: quotes * eslint fix: loosely-restrict-imports/loosely-restrict-imports * fix: Add Polyfill for IE11 support (#117) * IE11 Polyfill for babel * Removing Object.includes from Datepicker * fix package.json sort * fix: init coverage (#119) * add helper package.json scripts * emit coverage for travis run * add build for fix branches * fix: move lint extend react-app to eslintrc. comment out due to failing rules (#118) * more lint extend react-app to eslintrc. comment out due to failing rules * remove test scripts * adds additional class that adds space between the components, remove navbar component (#120) * Issue#121: refactor search input (#122) * Issue#90: adds shellbar component implementation, popover refactoring (#123) * Issue#90: adds shellbar component implementation, popover refactoring * Issue#90: failing test for popover * Update README.md * Adds a button that shows/hides the example code snippets (#127) * Update webpack dev server (#131) * update webpack-dev-server to 3.1.14 * update * fix failing unit test * Feature/issue#93 spreading props (#129) * Issue#93: adds className and spread props for Button and ActionBar * Issue#93: adds className and spread props for Alert and Status Indicators * Issue#93: adds className and spread props for Breadcrumb and Calendar * Issue#93: fix broken tests * Issue#93: adds className and spread props Combobox, DatePicker and Dropdown * Issue#93: adds className and spread props for Forms * Issue#93: adds className and spread props for Icon, Identifier and Image * Issue#93: adds className and spread props for the rest of the components * Issue#93: adds ...props for the Popover, Search Input and Tabs * Issue#93: adds omitted ...props for the Calendar, adds new snapshots for Dropdown and Popover after adding ...props * Update unit tests (#132) * update unit tests * updated test cases for className, init test for ShellBar * fixes the broken Show Code btn functionality * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Adds icons and notification count in the dropdown menu when items col… (#128) * Adds icons and notification count in the dropdown menu when items collapse * fixes failing tests and build * deals with some console warnings realted to passing the props from Date Picker to Calendar * #130 fix the library build (#133) * Implement a "copy" button in the playground code snippets (#135) * 📚 issue #124 add copy button for documentation code * 📚 issue #124 center button * 📚 issue #124 fix css error * #137 downgrade the version of webpack-dev-server to 3.19 as react-script@2.1.2 depends on that version (#138) * FOR DISCUSSION - Enhancement/improvements for search input component (#136) * adds onChange props, option to hide the search btn and compact mode for Search Input component * adds new snapshot for the search input test * adds an example with custom onChange func * automate versioning and publish via travis (#140) * remove limiting branches (#144) * chore: merge master into develop [ci skip] * remove beta (#146) * switch travis to fundamental-bot (#148) * Update README.md * Update README.md * Update README.md * fix: move deploy to jobs (#149) * move deploy to build * trigger build * chore: merge master into develop [ci skip] * fix: add standard-version to package.json (#153) * remove pull request limitation * add standard version to package.json * fix: add pack PR limiter (#155) * fix: merge conflicts (#157) * fix merge conflicts * prevent pushing merge conflicts
greg-a-smith
pushed a commit
that referenced
this pull request
Mar 5, 2019
greg-a-smith
pushed a commit
that referenced
this pull request
Mar 5, 2019
* fix: eject from create react app; prep for linting (#107) * eject from create react app; prep for linting * remove babel config from package.json * fix: cleanup package (#116) * sort deps * remove npm warning about missing repostory field * remove dupe jest dep warning * fix: init linting (#106) * init lint; comment out failing lints * eslint fix: comma-dangle * eslint fix: comma-spacing * eslint fix: comma-style * eslint fix: dot-notation * eslint fix: eol-last * eslint fix: keyword-spacing * eslint fix: jsx-quotes * eslint fix: no-multi-spaces * eslint fix: no-trailing-spaces * eslint fix: quote-props * eslint fix: semi * eslint fix: space-before-blocks * eslint fix: semi-spacing * eslint fix: space-infix-ops * eslint fix: space-before-function-paren * eslint fix: react/sort-prop-types * eslint fix: react/self-closing-comp * eslint fix: react/prop-types * eslint fix: react/jsx-tag-spacing * eslint fix: react/jsx-max-props-per-line * eslint fix: react/jsx-indent-props * eslint fix: react/jsx-indent * eslint fix: react/jsx-equals-spacing * eslint fix: react/jsx-closing-bracket-location * eslint fix: react/jsx-boolean-value * eslint fix: quotes * eslint fix: loosely-restrict-imports/loosely-restrict-imports * fix: Add Polyfill for IE11 support (#117) * IE11 Polyfill for babel * Removing Object.includes from Datepicker * fix package.json sort * fix: init coverage (#119) * add helper package.json scripts * emit coverage for travis run * add build for fix branches * fix: move lint extend react-app to eslintrc. comment out due to failing rules (#118) * more lint extend react-app to eslintrc. comment out due to failing rules * remove test scripts * adds additional class that adds space between the components, remove navbar component (#120) * Issue#121: refactor search input (#122) * Issue#90: adds shellbar component implementation, popover refactoring (#123) * Issue#90: adds shellbar component implementation, popover refactoring * Issue#90: failing test for popover * Update README.md * Adds a button that shows/hides the example code snippets (#127) * Update webpack dev server (#131) * update webpack-dev-server to 3.1.14 * update * fix failing unit test * Feature/issue#93 spreading props (#129) * Issue#93: adds className and spread props for Button and ActionBar * Issue#93: adds className and spread props for Alert and Status Indicators * Issue#93: adds className and spread props for Breadcrumb and Calendar * Issue#93: fix broken tests * Issue#93: adds className and spread props Combobox, DatePicker and Dropdown * Issue#93: adds className and spread props for Forms * Issue#93: adds className and spread props for Icon, Identifier and Image * Issue#93: adds className and spread props for the rest of the components * Issue#93: adds ...props for the Popover, Search Input and Tabs * Issue#93: adds omitted ...props for the Calendar, adds new snapshots for Dropdown and Popover after adding ...props * Update unit tests (#132) * update unit tests * updated test cases for className, init test for ShellBar * fixes the broken Show Code btn functionality * Update README.md * Adds icons and notification count in the dropdown menu when items col… (#128) * Adds icons and notification count in the dropdown menu when items collapse * fixes failing tests and build * deals with some console warnings realted to passing the props from Date Picker to Calendar * #130 fix the library build (#133) * Implement a "copy" button in the playground code snippets (#135) * 📚 issue #124 add copy button for documentation code * 📚 issue #124 center button * 📚 issue #124 fix css error
greg-a-smith
pushed a commit
that referenced
this pull request
Mar 5, 2019
* fix: eject from create react app; prep for linting (#107) * eject from create react app; prep for linting * remove babel config from package.json * fix: cleanup package (#116) * sort deps * remove npm warning about missing repostory field * remove dupe jest dep warning * fix: init linting (#106) * init lint; comment out failing lints * eslint fix: comma-dangle * eslint fix: comma-spacing * eslint fix: comma-style * eslint fix: dot-notation * eslint fix: eol-last * eslint fix: keyword-spacing * eslint fix: jsx-quotes * eslint fix: no-multi-spaces * eslint fix: no-trailing-spaces * eslint fix: quote-props * eslint fix: semi * eslint fix: space-before-blocks * eslint fix: semi-spacing * eslint fix: space-infix-ops * eslint fix: space-before-function-paren * eslint fix: react/sort-prop-types * eslint fix: react/self-closing-comp * eslint fix: react/prop-types * eslint fix: react/jsx-tag-spacing * eslint fix: react/jsx-max-props-per-line * eslint fix: react/jsx-indent-props * eslint fix: react/jsx-indent * eslint fix: react/jsx-equals-spacing * eslint fix: react/jsx-closing-bracket-location * eslint fix: react/jsx-boolean-value * eslint fix: quotes * eslint fix: loosely-restrict-imports/loosely-restrict-imports * fix: Add Polyfill for IE11 support (#117) * IE11 Polyfill for babel * Removing Object.includes from Datepicker * fix package.json sort * fix: init coverage (#119) * add helper package.json scripts * emit coverage for travis run * add build for fix branches * fix: move lint extend react-app to eslintrc. comment out due to failing rules (#118) * more lint extend react-app to eslintrc. comment out due to failing rules * remove test scripts * adds additional class that adds space between the components, remove navbar component (#120) * Issue#121: refactor search input (#122) * Issue#90: adds shellbar component implementation, popover refactoring (#123) * Issue#90: adds shellbar component implementation, popover refactoring * Issue#90: failing test for popover * Update README.md * Adds a button that shows/hides the example code snippets (#127) * Update webpack dev server (#131) * update webpack-dev-server to 3.1.14 * update * fix failing unit test * Feature/issue#93 spreading props (#129) * Issue#93: adds className and spread props for Button and ActionBar * Issue#93: adds className and spread props for Alert and Status Indicators * Issue#93: adds className and spread props for Breadcrumb and Calendar * Issue#93: fix broken tests * Issue#93: adds className and spread props Combobox, DatePicker and Dropdown * Issue#93: adds className and spread props for Forms * Issue#93: adds className and spread props for Icon, Identifier and Image * Issue#93: adds className and spread props for the rest of the components * Issue#93: adds ...props for the Popover, Search Input and Tabs * Issue#93: adds omitted ...props for the Calendar, adds new snapshots for Dropdown and Popover after adding ...props * Update unit tests (#132) * update unit tests * updated test cases for className, init test for ShellBar * fixes the broken Show Code btn functionality * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Adds icons and notification count in the dropdown menu when items col… (#128) * Adds icons and notification count in the dropdown menu when items collapse * fixes failing tests and build * deals with some console warnings realted to passing the props from Date Picker to Calendar * #130 fix the library build (#133) * Implement a "copy" button in the playground code snippets (#135) * 📚 issue #124 add copy button for documentation code * 📚 issue #124 center button * 📚 issue #124 fix css error * #137 downgrade the version of webpack-dev-server to 3.19 as react-script@2.1.2 depends on that version (#138) * FOR DISCUSSION - Enhancement/improvements for search input component (#136) * adds onChange props, option to hide the search btn and compact mode for Search Input component * adds new snapshot for the search input test * adds an example with custom onChange func * automate versioning and publish via travis (#140)
greg-a-smith
pushed a commit
that referenced
this pull request
Mar 5, 2019
* fix: eject from create react app; prep for linting (#107) * eject from create react app; prep for linting * remove babel config from package.json * fix: cleanup package (#116) * sort deps * remove npm warning about missing repostory field * remove dupe jest dep warning * fix: init linting (#106) * init lint; comment out failing lints * eslint fix: comma-dangle * eslint fix: comma-spacing * eslint fix: comma-style * eslint fix: dot-notation * eslint fix: eol-last * eslint fix: keyword-spacing * eslint fix: jsx-quotes * eslint fix: no-multi-spaces * eslint fix: no-trailing-spaces * eslint fix: quote-props * eslint fix: semi * eslint fix: space-before-blocks * eslint fix: semi-spacing * eslint fix: space-infix-ops * eslint fix: space-before-function-paren * eslint fix: react/sort-prop-types * eslint fix: react/self-closing-comp * eslint fix: react/prop-types * eslint fix: react/jsx-tag-spacing * eslint fix: react/jsx-max-props-per-line * eslint fix: react/jsx-indent-props * eslint fix: react/jsx-indent * eslint fix: react/jsx-equals-spacing * eslint fix: react/jsx-closing-bracket-location * eslint fix: react/jsx-boolean-value * eslint fix: quotes * eslint fix: loosely-restrict-imports/loosely-restrict-imports * fix: Add Polyfill for IE11 support (#117) * IE11 Polyfill for babel * Removing Object.includes from Datepicker * fix package.json sort * fix: init coverage (#119) * add helper package.json scripts * emit coverage for travis run * add build for fix branches * fix: move lint extend react-app to eslintrc. comment out due to failing rules (#118) * more lint extend react-app to eslintrc. comment out due to failing rules * remove test scripts * adds additional class that adds space between the components, remove navbar component (#120) * Issue#121: refactor search input (#122) * Issue#90: adds shellbar component implementation, popover refactoring (#123) * Issue#90: adds shellbar component implementation, popover refactoring * Issue#90: failing test for popover * Update README.md * Adds a button that shows/hides the example code snippets (#127) * Update webpack dev server (#131) * update webpack-dev-server to 3.1.14 * update * fix failing unit test * Feature/issue#93 spreading props (#129) * Issue#93: adds className and spread props for Button and ActionBar * Issue#93: adds className and spread props for Alert and Status Indicators * Issue#93: adds className and spread props for Breadcrumb and Calendar * Issue#93: fix broken tests * Issue#93: adds className and spread props Combobox, DatePicker and Dropdown * Issue#93: adds className and spread props for Forms * Issue#93: adds className and spread props for Icon, Identifier and Image * Issue#93: adds className and spread props for the rest of the components * Issue#93: adds ...props for the Popover, Search Input and Tabs * Issue#93: adds omitted ...props for the Calendar, adds new snapshots for Dropdown and Popover after adding ...props * Update unit tests (#132) * update unit tests * updated test cases for className, init test for ShellBar * fixes the broken Show Code btn functionality * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Adds icons and notification count in the dropdown menu when items col… (#128) * Adds icons and notification count in the dropdown menu when items collapse * fixes failing tests and build * deals with some console warnings realted to passing the props from Date Picker to Calendar * #130 fix the library build (#133) * Implement a "copy" button in the playground code snippets (#135) * 📚 issue #124 add copy button for documentation code * 📚 issue #124 center button * 📚 issue #124 fix css error * #137 downgrade the version of webpack-dev-server to 3.19 as react-script@2.1.2 depends on that version (#138) * FOR DISCUSSION - Enhancement/improvements for search input component (#136) * adds onChange props, option to hide the search btn and compact mode for Search Input component * adds new snapshot for the search input test * adds an example with custom onChange func * automate versioning and publish via travis (#140)
greg-a-smith
pushed a commit
that referenced
this pull request
Mar 5, 2019
* fix: eject from create react app; prep for linting (#107) * eject from create react app; prep for linting * remove babel config from package.json * fix: cleanup package (#116) * sort deps * remove npm warning about missing repostory field * remove dupe jest dep warning * fix: init linting (#106) * init lint; comment out failing lints * eslint fix: comma-dangle * eslint fix: comma-spacing * eslint fix: comma-style * eslint fix: dot-notation * eslint fix: eol-last * eslint fix: keyword-spacing * eslint fix: jsx-quotes * eslint fix: no-multi-spaces * eslint fix: no-trailing-spaces * eslint fix: quote-props * eslint fix: semi * eslint fix: space-before-blocks * eslint fix: semi-spacing * eslint fix: space-infix-ops * eslint fix: space-before-function-paren * eslint fix: react/sort-prop-types * eslint fix: react/self-closing-comp * eslint fix: react/prop-types * eslint fix: react/jsx-tag-spacing * eslint fix: react/jsx-max-props-per-line * eslint fix: react/jsx-indent-props * eslint fix: react/jsx-indent * eslint fix: react/jsx-equals-spacing * eslint fix: react/jsx-closing-bracket-location * eslint fix: react/jsx-boolean-value * eslint fix: quotes * eslint fix: loosely-restrict-imports/loosely-restrict-imports * fix: Add Polyfill for IE11 support (#117) * IE11 Polyfill for babel * Removing Object.includes from Datepicker * fix package.json sort * fix: init coverage (#119) * add helper package.json scripts * emit coverage for travis run * add build for fix branches * fix: move lint extend react-app to eslintrc. comment out due to failing rules (#118) * more lint extend react-app to eslintrc. comment out due to failing rules * remove test scripts * adds additional class that adds space between the components, remove navbar component (#120) * Issue#121: refactor search input (#122) * Issue#90: adds shellbar component implementation, popover refactoring (#123) * Issue#90: adds shellbar component implementation, popover refactoring * Issue#90: failing test for popover * Update README.md * Adds a button that shows/hides the example code snippets (#127) * Update webpack dev server (#131) * update webpack-dev-server to 3.1.14 * update * fix failing unit test * Feature/issue#93 spreading props (#129) * Issue#93: adds className and spread props for Button and ActionBar * Issue#93: adds className and spread props for Alert and Status Indicators * Issue#93: adds className and spread props for Breadcrumb and Calendar * Issue#93: fix broken tests * Issue#93: adds className and spread props Combobox, DatePicker and Dropdown * Issue#93: adds className and spread props for Forms * Issue#93: adds className and spread props for Icon, Identifier and Image * Issue#93: adds className and spread props for the rest of the components * Issue#93: adds ...props for the Popover, Search Input and Tabs * Issue#93: adds omitted ...props for the Calendar, adds new snapshots for Dropdown and Popover after adding ...props * Update unit tests (#132) * update unit tests * updated test cases for className, init test for ShellBar * fixes the broken Show Code btn functionality * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Adds icons and notification count in the dropdown menu when items col… (#128) * Adds icons and notification count in the dropdown menu when items collapse * fixes failing tests and build * deals with some console warnings realted to passing the props from Date Picker to Calendar * #130 fix the library build (#133) * Implement a "copy" button in the playground code snippets (#135) * 📚 issue #124 add copy button for documentation code * 📚 issue #124 center button * 📚 issue #124 fix css error * #137 downgrade the version of webpack-dev-server to 3.19 as react-script@2.1.2 depends on that version (#138) * FOR DISCUSSION - Enhancement/improvements for search input component (#136) * adds onChange props, option to hide the search btn and compact mode for Search Input component * adds new snapshot for the search input test * adds an example with custom onChange func * automate versioning and publish via travis (#140) * remove limiting branches (#144)
greg-a-smith
pushed a commit
that referenced
this pull request
Mar 5, 2019
* fix: eject from create react app; prep for linting (#107) * eject from create react app; prep for linting * remove babel config from package.json * fix: cleanup package (#116) * sort deps * remove npm warning about missing repostory field * remove dupe jest dep warning * fix: init linting (#106) * init lint; comment out failing lints * eslint fix: comma-dangle * eslint fix: comma-spacing * eslint fix: comma-style * eslint fix: dot-notation * eslint fix: eol-last * eslint fix: keyword-spacing * eslint fix: jsx-quotes * eslint fix: no-multi-spaces * eslint fix: no-trailing-spaces * eslint fix: quote-props * eslint fix: semi * eslint fix: space-before-blocks * eslint fix: semi-spacing * eslint fix: space-infix-ops * eslint fix: space-before-function-paren * eslint fix: react/sort-prop-types * eslint fix: react/self-closing-comp * eslint fix: react/prop-types * eslint fix: react/jsx-tag-spacing * eslint fix: react/jsx-max-props-per-line * eslint fix: react/jsx-indent-props * eslint fix: react/jsx-indent * eslint fix: react/jsx-equals-spacing * eslint fix: react/jsx-closing-bracket-location * eslint fix: react/jsx-boolean-value * eslint fix: quotes * eslint fix: loosely-restrict-imports/loosely-restrict-imports * fix: Add Polyfill for IE11 support (#117) * IE11 Polyfill for babel * Removing Object.includes from Datepicker * fix package.json sort * fix: init coverage (#119) * add helper package.json scripts * emit coverage for travis run * add build for fix branches * fix: move lint extend react-app to eslintrc. comment out due to failing rules (#118) * more lint extend react-app to eslintrc. comment out due to failing rules * remove test scripts * adds additional class that adds space between the components, remove navbar component (#120) * Issue#121: refactor search input (#122) * Issue#90: adds shellbar component implementation, popover refactoring (#123) * Issue#90: adds shellbar component implementation, popover refactoring * Issue#90: failing test for popover * Update README.md * Adds a button that shows/hides the example code snippets (#127) * Update webpack dev server (#131) * update webpack-dev-server to 3.1.14 * update * fix failing unit test * Feature/issue#93 spreading props (#129) * Issue#93: adds className and spread props for Button and ActionBar * Issue#93: adds className and spread props for Alert and Status Indicators * Issue#93: adds className and spread props for Breadcrumb and Calendar * Issue#93: fix broken tests * Issue#93: adds className and spread props Combobox, DatePicker and Dropdown * Issue#93: adds className and spread props for Forms * Issue#93: adds className and spread props for Icon, Identifier and Image * Issue#93: adds className and spread props for the rest of the components * Issue#93: adds ...props for the Popover, Search Input and Tabs * Issue#93: adds omitted ...props for the Calendar, adds new snapshots for Dropdown and Popover after adding ...props * Update unit tests (#132) * update unit tests * updated test cases for className, init test for ShellBar * fixes the broken Show Code btn functionality * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Adds icons and notification count in the dropdown menu when items col… (#128) * Adds icons and notification count in the dropdown menu when items collapse * fixes failing tests and build * deals with some console warnings realted to passing the props from Date Picker to Calendar * #130 fix the library build (#133) * Implement a "copy" button in the playground code snippets (#135) * 📚 issue #124 add copy button for documentation code * 📚 issue #124 center button * 📚 issue #124 fix css error * #137 downgrade the version of webpack-dev-server to 3.19 as react-script@2.1.2 depends on that version (#138) * FOR DISCUSSION - Enhancement/improvements for search input component (#136) * adds onChange props, option to hide the search btn and compact mode for Search Input component * adds new snapshot for the search input test * adds an example with custom onChange func * automate versioning and publish via travis (#140) * remove limiting branches (#144) * chore: merge master into develop [ci skip] * remove beta (#146)
greg-a-smith
pushed a commit
that referenced
this pull request
Mar 5, 2019
* fix: eject from create react app; prep for linting (#107) * eject from create react app; prep for linting * remove babel config from package.json * fix: cleanup package (#116) * sort deps * remove npm warning about missing repostory field * remove dupe jest dep warning * fix: init linting (#106) * init lint; comment out failing lints * eslint fix: comma-dangle * eslint fix: comma-spacing * eslint fix: comma-style * eslint fix: dot-notation * eslint fix: eol-last * eslint fix: keyword-spacing * eslint fix: jsx-quotes * eslint fix: no-multi-spaces * eslint fix: no-trailing-spaces * eslint fix: quote-props * eslint fix: semi * eslint fix: space-before-blocks * eslint fix: semi-spacing * eslint fix: space-infix-ops * eslint fix: space-before-function-paren * eslint fix: react/sort-prop-types * eslint fix: react/self-closing-comp * eslint fix: react/prop-types * eslint fix: react/jsx-tag-spacing * eslint fix: react/jsx-max-props-per-line * eslint fix: react/jsx-indent-props * eslint fix: react/jsx-indent * eslint fix: react/jsx-equals-spacing * eslint fix: react/jsx-closing-bracket-location * eslint fix: react/jsx-boolean-value * eslint fix: quotes * eslint fix: loosely-restrict-imports/loosely-restrict-imports * fix: Add Polyfill for IE11 support (#117) * IE11 Polyfill for babel * Removing Object.includes from Datepicker * fix package.json sort * fix: init coverage (#119) * add helper package.json scripts * emit coverage for travis run * add build for fix branches * fix: move lint extend react-app to eslintrc. comment out due to failing rules (#118) * more lint extend react-app to eslintrc. comment out due to failing rules * remove test scripts * adds additional class that adds space between the components, remove navbar component (#120) * Issue#121: refactor search input (#122) * Issue#90: adds shellbar component implementation, popover refactoring (#123) * Issue#90: adds shellbar component implementation, popover refactoring * Issue#90: failing test for popover * Update README.md * Adds a button that shows/hides the example code snippets (#127) * Update webpack dev server (#131) * update webpack-dev-server to 3.1.14 * update * fix failing unit test * Feature/issue#93 spreading props (#129) * Issue#93: adds className and spread props for Button and ActionBar * Issue#93: adds className and spread props for Alert and Status Indicators * Issue#93: adds className and spread props for Breadcrumb and Calendar * Issue#93: fix broken tests * Issue#93: adds className and spread props Combobox, DatePicker and Dropdown * Issue#93: adds className and spread props for Forms * Issue#93: adds className and spread props for Icon, Identifier and Image * Issue#93: adds className and spread props for the rest of the components * Issue#93: adds ...props for the Popover, Search Input and Tabs * Issue#93: adds omitted ...props for the Calendar, adds new snapshots for Dropdown and Popover after adding ...props * Update unit tests (#132) * update unit tests * updated test cases for className, init test for ShellBar * fixes the broken Show Code btn functionality * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Adds icons and notification count in the dropdown menu when items col… (#128) * Adds icons and notification count in the dropdown menu when items collapse * fixes failing tests and build * deals with some console warnings realted to passing the props from Date Picker to Calendar * #130 fix the library build (#133) * Implement a "copy" button in the playground code snippets (#135) * 📚 issue #124 add copy button for documentation code * 📚 issue #124 center button * 📚 issue #124 fix css error * #137 downgrade the version of webpack-dev-server to 3.19 as react-script@2.1.2 depends on that version (#138) * FOR DISCUSSION - Enhancement/improvements for search input component (#136) * adds onChange props, option to hide the search btn and compact mode for Search Input component * adds new snapshot for the search input test * adds an example with custom onChange func * automate versioning and publish via travis (#140) * remove limiting branches (#144) * chore: merge master into develop [ci skip] * remove beta (#146) * switch travis to fundamental-bot (#148) * Update README.md * Update README.md * Update README.md * fix: move deploy to jobs (#149) * move deploy to build * trigger build
greg-a-smith
pushed a commit
that referenced
this pull request
Mar 5, 2019
* fix: eject from create react app; prep for linting (#107) * eject from create react app; prep for linting * remove babel config from package.json * fix: cleanup package (#116) * sort deps * remove npm warning about missing repostory field * remove dupe jest dep warning * fix: init linting (#106) * init lint; comment out failing lints * eslint fix: comma-dangle * eslint fix: comma-spacing * eslint fix: comma-style * eslint fix: dot-notation * eslint fix: eol-last * eslint fix: keyword-spacing * eslint fix: jsx-quotes * eslint fix: no-multi-spaces * eslint fix: no-trailing-spaces * eslint fix: quote-props * eslint fix: semi * eslint fix: space-before-blocks * eslint fix: semi-spacing * eslint fix: space-infix-ops * eslint fix: space-before-function-paren * eslint fix: react/sort-prop-types * eslint fix: react/self-closing-comp * eslint fix: react/prop-types * eslint fix: react/jsx-tag-spacing * eslint fix: react/jsx-max-props-per-line * eslint fix: react/jsx-indent-props * eslint fix: react/jsx-indent * eslint fix: react/jsx-equals-spacing * eslint fix: react/jsx-closing-bracket-location * eslint fix: react/jsx-boolean-value * eslint fix: quotes * eslint fix: loosely-restrict-imports/loosely-restrict-imports * fix: Add Polyfill for IE11 support (#117) * IE11 Polyfill for babel * Removing Object.includes from Datepicker * fix package.json sort * fix: init coverage (#119) * add helper package.json scripts * emit coverage for travis run * add build for fix branches * fix: move lint extend react-app to eslintrc. comment out due to failing rules (#118) * more lint extend react-app to eslintrc. comment out due to failing rules * remove test scripts * adds additional class that adds space between the components, remove navbar component (#120) * Issue#121: refactor search input (#122) * Issue#90: adds shellbar component implementation, popover refactoring (#123) * Issue#90: adds shellbar component implementation, popover refactoring * Issue#90: failing test for popover * Update README.md * Adds a button that shows/hides the example code snippets (#127) * Update webpack dev server (#131) * update webpack-dev-server to 3.1.14 * update * fix failing unit test * Feature/issue#93 spreading props (#129) * Issue#93: adds className and spread props for Button and ActionBar * Issue#93: adds className and spread props for Alert and Status Indicators * Issue#93: adds className and spread props for Breadcrumb and Calendar * Issue#93: fix broken tests * Issue#93: adds className and spread props Combobox, DatePicker and Dropdown * Issue#93: adds className and spread props for Forms * Issue#93: adds className and spread props for Icon, Identifier and Image * Issue#93: adds className and spread props for the rest of the components * Issue#93: adds ...props for the Popover, Search Input and Tabs * Issue#93: adds omitted ...props for the Calendar, adds new snapshots for Dropdown and Popover after adding ...props * Update unit tests (#132) * update unit tests * updated test cases for className, init test for ShellBar * fixes the broken Show Code btn functionality * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Adds icons and notification count in the dropdown menu when items col… (#128) * Adds icons and notification count in the dropdown menu when items collapse * fixes failing tests and build * deals with some console warnings realted to passing the props from Date Picker to Calendar * #130 fix the library build (#133) * Implement a "copy" button in the playground code snippets (#135) * 📚 issue #124 add copy button for documentation code * 📚 issue #124 center button * 📚 issue #124 fix css error * #137 downgrade the version of webpack-dev-server to 3.19 as react-script@2.1.2 depends on that version (#138) * FOR DISCUSSION - Enhancement/improvements for search input component (#136) * adds onChange props, option to hide the search btn and compact mode for Search Input component * adds new snapshot for the search input test * adds an example with custom onChange func * automate versioning and publish via travis (#140) * remove limiting branches (#144) * chore: merge master into develop [ci skip] * remove beta (#146) * switch travis to fundamental-bot (#148) * Update README.md * Update README.md * Update README.md * fix: move deploy to jobs (#149) * move deploy to build * trigger build
greg-a-smith
pushed a commit
that referenced
this pull request
Mar 5, 2019
* fix: eject from create react app; prep for linting (#107) * eject from create react app; prep for linting * remove babel config from package.json * fix: cleanup package (#116) * sort deps * remove npm warning about missing repostory field * remove dupe jest dep warning * fix: init linting (#106) * init lint; comment out failing lints * eslint fix: comma-dangle * eslint fix: comma-spacing * eslint fix: comma-style * eslint fix: dot-notation * eslint fix: eol-last * eslint fix: keyword-spacing * eslint fix: jsx-quotes * eslint fix: no-multi-spaces * eslint fix: no-trailing-spaces * eslint fix: quote-props * eslint fix: semi * eslint fix: space-before-blocks * eslint fix: semi-spacing * eslint fix: space-infix-ops * eslint fix: space-before-function-paren * eslint fix: react/sort-prop-types * eslint fix: react/self-closing-comp * eslint fix: react/prop-types * eslint fix: react/jsx-tag-spacing * eslint fix: react/jsx-max-props-per-line * eslint fix: react/jsx-indent-props * eslint fix: react/jsx-indent * eslint fix: react/jsx-equals-spacing * eslint fix: react/jsx-closing-bracket-location * eslint fix: react/jsx-boolean-value * eslint fix: quotes * eslint fix: loosely-restrict-imports/loosely-restrict-imports * fix: Add Polyfill for IE11 support (#117) * IE11 Polyfill for babel * Removing Object.includes from Datepicker * fix package.json sort * fix: init coverage (#119) * add helper package.json scripts * emit coverage for travis run * add build for fix branches * fix: move lint extend react-app to eslintrc. comment out due to failing rules (#118) * more lint extend react-app to eslintrc. comment out due to failing rules * remove test scripts * adds additional class that adds space between the components, remove navbar component (#120) * Issue#121: refactor search input (#122) * Issue#90: adds shellbar component implementation, popover refactoring (#123) * Issue#90: adds shellbar component implementation, popover refactoring * Issue#90: failing test for popover * Update README.md * Adds a button that shows/hides the example code snippets (#127) * Update webpack dev server (#131) * update webpack-dev-server to 3.1.14 * update * fix failing unit test * Feature/issue#93 spreading props (#129) * Issue#93: adds className and spread props for Button and ActionBar * Issue#93: adds className and spread props for Alert and Status Indicators * Issue#93: adds className and spread props for Breadcrumb and Calendar * Issue#93: fix broken tests * Issue#93: adds className and spread props Combobox, DatePicker and Dropdown * Issue#93: adds className and spread props for Forms * Issue#93: adds className and spread props for Icon, Identifier and Image * Issue#93: adds className and spread props for the rest of the components * Issue#93: adds ...props for the Popover, Search Input and Tabs * Issue#93: adds omitted ...props for the Calendar, adds new snapshots for Dropdown and Popover after adding ...props * Update unit tests (#132) * update unit tests * updated test cases for className, init test for ShellBar * fixes the broken Show Code btn functionality * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Adds icons and notification count in the dropdown menu when items col… (#128) * Adds icons and notification count in the dropdown menu when items collapse * fixes failing tests and build * deals with some console warnings realted to passing the props from Date Picker to Calendar * #130 fix the library build (#133) * Implement a "copy" button in the playground code snippets (#135) * 📚 issue #124 add copy button for documentation code * 📚 issue #124 center button * 📚 issue #124 fix css error * #137 downgrade the version of webpack-dev-server to 3.19 as react-script@2.1.2 depends on that version (#138) * FOR DISCUSSION - Enhancement/improvements for search input component (#136) * adds onChange props, option to hide the search btn and compact mode for Search Input component * adds new snapshot for the search input test * adds an example with custom onChange func * automate versioning and publish via travis (#140) * remove limiting branches (#144) * chore: merge master into develop [ci skip] * remove beta (#146) * switch travis to fundamental-bot (#148) * Update README.md * Update README.md * Update README.md * fix: move deploy to jobs (#149) * move deploy to build * trigger build * chore: merge master into develop [ci skip] * fix: add standard-version to package.json (#153) * remove pull request limitation * add standard version to package.json * fix: add pack PR limiter (#155)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.