Skip to content

Conversation

@greg-a-smith
Copy link
Contributor

@greg-a-smith greg-a-smith commented Apr 5, 2019

Description

It was found in the fundamental repo that the calls to GitHub API to build the release notes could happen prior to the commits being pushed (or updated within GitHub). To help ensure this works, I have moved the create release call below publish.

Also, updated to a new version of github-assistant that will include a "Documentation" section in the release notes.

Example

Screen Shot 2019-04-05 at 2 08 57 PM

@greg-a-smith greg-a-smith requested a review from a team April 5, 2019 14:15
Copy link
Contributor

@jbadan jbadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@greg-a-smith greg-a-smith merged commit f7daace into master Apr 8, 2019
@greg-a-smith greg-a-smith deleted the chore/release-notes branch April 8, 2019 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants