feat: removing lib from import statement #573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for fundamental-react ready! Built with commit ac904b4 |
jbadan
requested changes
Jun 7, 2019
Contributor
jbadan
left a comment
jbadan
left a comment
There was a problem hiding this comment.
This looks great! 🎉
We also need to update the import component to remove lib so that the imports are updated on all the component pages on the documentation site:
https://github.com/SAP/fundamental-react/blob/master/src/_playground/documentation/Import/Import.js#L21
hertweckhr1
changed the title
jbadan
approved these changes
Jun 7, 2019
Contributor
jbadan
left a comment
jbadan
left a comment
There was a problem hiding this comment.
Once you move the build script I'm happy with this!! 🚢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Copied package-json, ReadMe, ChangeLog, and License into lib folder then published directly from lib folder in order to eliminate lib from the import statement.
We should now be able to import any component with
import {<component}> from 'fundamental-react/<component>'instead ofimport {<component}> from 'fundamental-react/lib/<component>'I tested on a forked branch to make sure this worked:
import { Button } from 'fundamental-react-hannah/Button';fixes #399