Skip to content

Conversation

@SydneyMonis
Copy link
Contributor

Added the 'defaultValue' prop to the DatePicker component, where a date string can be passed in the ISO format to get a default date on the DatePicker, also includes some minor refactoring by extracting out a method out of a line of code that is repeated several times.

fixes #822

@claassistantio
Copy link

claassistantio commented Jan 6, 2020

CLA assistant check
All committers have signed the CLA.

@claassistantio
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ jacobdevera
❌ Sydney Monis


Sydney Monis seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@SydneyMonis SydneyMonis changed the title Defaulting datepicker value fix: provided a 'defaultValue' prop to the DatePicker Jan 6, 2020
@netlify
Copy link

netlify bot commented Jan 6, 2020

Deploy preview for fundamental-react ready!

Built with commit be99a33

https://deploy-preview-844--fundamental-react.netlify.com

jbadan
jbadan previously requested changes Jan 6, 2020
Copy link
Contributor

@jbadan jbadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SydneyMonis commit 01a4c6c cannot be in this pr. It has a commit message that will cause 1.0.0 to be released 😞

@jbadan jbadan requested a review from a team January 6, 2020 16:48
@SydneyMonis SydneyMonis force-pushed the defaulting-datepicker-value branch from 910953e to be99a33 Compare January 7, 2020 04:27
@SydneyMonis
Copy link
Contributor Author

@SydneyMonis commit 01a4c6c cannot be in this pr. It has a commit message that will cause 1.0.0 to be released 😞

Hi Jenna, I have removed that commit now.

@jbadan jbadan dismissed their stale review January 7, 2020 16:36

Removed commit

@jbadan jbadan requested a review from jacobdevera January 7, 2020 16:37
@bcullman
Copy link
Contributor

bcullman commented Jan 7, 2020

@SydneyMonis - a reminder that in addition to being blocked by review, your PR is also blocked by CLA. You will need to e-sign that as well.

@SydneyMonis
Copy link
Contributor Author

@SydneyMonis - a reminder that in addition to being blocked by review, your PR is also blocked by CLA. You will need to e-sign that as well.

Hey ! I did that but weirdly it doesn't reflect. Here's a quick screen rec :: https://sapvideoa35699dc5.hana.ondemand.com/?entry_id=0_vcpypx9w

@bcullman
Copy link
Contributor

bcullman commented Jan 8, 2020

@SydneyMonis - check the message below the not signed yet badge, directed at you. It says

SydneyMonis seems to not be a github user. you need a github account to be able to sign the CLA. if you already have a github account, please add the email address you used fo this commit to your account (emphasis mine)

@SydneyMonis
Copy link
Contributor Author

@SydneyMonis - check the message below the not signed yet badge, directed at you. It says

SydneyMonis seems to not be a github user. you need a github account to be able to sign the CLA. if you already have a github account, please add the email address you used fo this commit to your account (emphasis mine)

Done !! Sorry for the confusion.

Copy link
Contributor

@jbadan jbadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@jbadan jbadan merged commit 034011d into SAP:master Jan 10, 2020
@bcullman
Copy link
Contributor

@SydneyMonis - no worries. Thanks for the contribution!

@SydneyMonis SydneyMonis deleted the defaulting-datepicker-value branch February 4, 2020 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ability to pass a default date to the DatePicker

5 participants