-
Notifications
You must be signed in to change notification settings - Fork 77
fix: provided a 'defaultValue' prop to the DatePicker #844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Sydney Monis seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Deploy preview for fundamental-react ready! Built with commit be99a33 |
jbadan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SydneyMonis commit 01a4c6c cannot be in this pr. It has a commit message that will cause 1.0.0 to be released 😞
…is default value should be a string in the ISO date format
910953e to
be99a33
Compare
Hi Jenna, I have removed that commit now. |
|
@SydneyMonis - a reminder that in addition to being blocked by review, your PR is also blocked by CLA. You will need to e-sign that as well. |
Hey ! I did that but weirdly it doesn't reflect. Here's a quick screen rec :: https://sapvideoa35699dc5.hana.ondemand.com/?entry_id=0_vcpypx9w |
|
@SydneyMonis - check the message below the not signed yet badge, directed at you. It says
|
Done !! Sorry for the confusion. |
jbadan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
|
@SydneyMonis - no worries. Thanks for the contribution! |
Added the 'defaultValue' prop to the DatePicker component, where a date string can be passed in the ISO format to get a default date on the DatePicker, also includes some minor refactoring by extracting out a method out of a line of code that is repeated several times.
fixes #822