fix: create modal manager, for Popover, on demand as a singleton #859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for fundamental-react ready! Built with commit 896f83c |
greg-a-smith
approved these changes
Jan 29, 2020
Contributor
greg-a-smith
left a comment
greg-a-smith
left a comment
There was a problem hiding this comment.
Nice find! Looks good. 🚢
skvale
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a script tag containing fundamental react was included in the
<head>of the document it was throwing an error.It looks like this was happening because the version of react-overlays that fundamental-react is using in the Popover depends on
document.body.appendChildto calculate the scrollbar width from the ModalManager's constructor.This change ensures that the calculation for
document.body.appendChildwill only happen when it is available.