Skip to content

fix:321 Accessibility updates for toggle component #925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Mar 18, 2020
Merged

fix:321 Accessibility updates for toggle component #925

merged 11 commits into from
Mar 18, 2020
+32 −2

Conversation

@singh-mahendra
Copy link
Contributor

@singh-mahendra singh-mahendra commented Mar 18, 2020

Description

Accessibility updates for toggle component

fixes #321

Mahendra Singh and others added 11 commits March 2, 2020 19:02
@singh-mahendra
parent d4328dc
0d97642 
author Mahendra Singh <singh.mahendra3006@gmail.com> 1583155922 +530
committer Mahendra Singh <singh.mahendra3006@gmail.com> 1583155922 +0530

feat#773: Added visiblePageTotal prop to Pagination component.
@singh-mahendra
Merge branch 'master' of https://github.com/SAP/fundamental-react
9ffdf28
@singh-mahendra
Merge branch 'master' of https://github.com/SAP/fundamental-react
f647233
@singh-mahendra
Merge branch 'master' of https://github.com/SAP/fundamental-react
7fa7650
@singh-mahendra
Added default value condition for SearchInput
488cc99
@singh-mahendra
Merge branch 'master' of https://github.com/SAP/fundamental-react int…
f9a1e35 
…o dev-fix#631
@singh-mahendra
code review
b1d036f
@singh-mahendra
Merge branch 'master' of https://github.com/SAP/fundamental-react int…
dba8373 
…o dev-fix#321
@singh-mahendra
Accessibility improvements for Switch/Toggle
0061dd5
@singh-mahendra
Updated snapshot
4225a47
@singh-mahendra
Merge branch 'master' of https://github.com/SAP/fundamental-react int…
016f772 
…o dev-fix#321
@netlify
Copy link

netlify bot commented Mar 18, 2020

Deploy preview for fundamental-react ready!

Built with commit 016f772

https://deploy-preview-925--fundamental-react.netlify.com

@jbadan jbadan requested a review from a team March 18, 2020 18:53
jbadan
jbadan approved these changes Mar 18, 2020
View reviewed changes
Copy link
Contributor

@jbadan jbadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 !

@jbadan jbadan merged commit d790fc7 into SAP:master Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbadan jbadan jbadan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Toggle Component: Improve accessibility

2 participants

@singh-mahendra @jbadan