feat: upgrade fundamental-styles to 0.8.0-rc.16 #957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for fundamental-react ready! Built with commit ea28cc1 |
skvale
reviewed
Apr 3, 2020
| key={month} name={month} | ||
| onClick={() => this.changeMonth(month)}> | ||
| onClick={() => this.changeMonth(month)} | ||
| onFocus={this.handleMonthFocus(month)}> |
Contributor
There was a problem hiding this comment.
should this be onFocus={() => this.handleMonthFocus(month)}>?
skvale
reviewed
Apr 3, 2020
| name={element} | ||
| onClick={() => this.changeYear(element)}> | ||
| onClick={() => this.changeYear(element)} | ||
| onFocus={this.handleYearFocus(element)}> |
Contributor
There was a problem hiding this comment.
should this be onFocus={() => this. handleYearFocus(element)}>?
skvale
reviewed
Apr 3, 2020
skvale
reviewed
Apr 3, 2020
| data-is-focused={day.isSame(currentDateDisplayed)} | ||
| key={copyDate} | ||
| onClick={isEnabledDate(day, this.props) ? () => this.dateClick(copyDate, enableRangeSelection) : null} | ||
| onFocus={this.handleDayFocus(day)} |
Contributor
There was a problem hiding this comment.
should this be onFocus={() => this.handleDayFocus(day)}?
Contributor
Author
There was a problem hiding this comment.
Lint complains about creating a function in a loop. This is why the function declarations you pointed out seem weird as well. Yes, even though the onClick looks the same, just the focus one triggered the lint rule.
skvale
reviewed
Apr 3, 2020
skvale
reviewed
Apr 3, 2020
jacobdevera
reviewed
Apr 3, 2020
jacobdevera
approved these changes
Apr 7, 2020
prsdthkr
approved these changes
Apr 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Calendar before:
Calendar after:
Radio/checkbox before:
Radio/checkbox after:
