feat: New Busy Indicator component #963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Deploy preview for fundamental-react ready! Built with commit f15f5cd |
- Added prop 'show' to show/hide Busy Indicator - Updated .size-limit
skvale
reviewed
Apr 10, 2020
skvale
reviewed
Apr 10, 2020
skvale
reviewed
Apr 10, 2020
Changes suggested in PR - Updated style class for "s" size - Added aria-label/aria-hidden - Updated to return null intead of fragments when component is hidden
skvale
reviewed
Apr 13, 2020
skvale
reviewed
Apr 13, 2020
skvale
approved these changes
Apr 13, 2020
Contributor
Author
|
Thanks for review @skvale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added Busy Indicator component
Implements #879