feat: upgrade app-studio-toolkit-types version#141
Merged
NetaMolcho merged 2 commits intomasterfrom Jun 14, 2021
Merged
Conversation
bd82
reviewed
Jun 10, 2021
| "ws": "7.4.6" | ||
| }, | ||
| "devDependencies": { | ||
| "@sap-devx/app-studio-toolkit-types": "1.0.0", |
bd82
reviewed
Jun 10, 2021
| if (context) { | ||
| switch (itemAction.action.actionType) { | ||
| case ActionType.Command: | ||
| case "COMMAND": |
Member
There was a problem hiding this comment.
it gave you auto-complete suggestions here, correct?
bd82
reviewed
Jun 10, 2021
| class testFileItemAction implements IFileAction { | ||
| actionType: ActionType; | ||
| uri: FileActionParams; | ||
| actionType: "FILE"; |
Member
There was a problem hiding this comment.
should not we change this to "URI" as "File" will get deprecated in ~2 months?
bd82
reviewed
Jun 10, 2021
|
|
||
| let action = new testFileItemAction(); | ||
| action.actionType = ActionType.File; | ||
| action.actionType = "FILE"; |
bd82
reviewed
Jun 10, 2021
| vscode.commands.executeCommand("loadCodeSnippet", { contributorId: snippetAction.contributorId, snippetName: snippetAction.snippetName, context: snippetAction.context }); | ||
| break; | ||
| case ActionType.File: | ||
| case "FILE": |
bd82
reviewed
Jun 10, 2021
| constructor() { | ||
| super(); | ||
| this.actionType = ActionType.File; | ||
| this.actionType = "FILE"; |
Member
There was a problem hiding this comment.
- why are there two initializations here for
actionType - FILE or URI?
bd82
reviewed
Jun 10, 2021
backend/tests/vscode-events.spec.ts
Outdated
| performAction: <T = void>(action: BasAction, options?: { schedule?: boolean }) => undefined, | ||
| actions: { | ||
| performAction: mockPerformAction, | ||
| performAction: <T = void>(action: BasAction, options?: { schedule?: boolean }) => undefined, |
Member
There was a problem hiding this comment.
instead of copying a complex signature may be able to reuse it.
performAction: basAPI["performAction"]
bd82
reviewed
Jun 10, 2021
| "dependencies": { | ||
| "@sap-devx/app-studio-toolkit-types": "0.0.1", | ||
| "@sap-devx/guided-development-types": "0.0.13", | ||
| "@sap-devx/app-studio-toolkit-types": "1.0.0", |
Member
There was a problem hiding this comment.
wow its horrible managing all these versions manually
bd82
reviewed
Jun 10, 2021
|
|
||
| let action = new testFileItemAction(); | ||
| action.actionType = ActionType.File; | ||
| action.actionType = "FILE"; |
bd82
reviewed
Jun 10, 2021
backend/tests/vscode-events.spec.ts
Outdated
| import * as _ from "lodash"; | ||
| import { Contributors } from "../src/contributors"; | ||
| import { ICommandAction, IExecuteAction, IFileAction, ISnippetAction, bas, IAction, ActionType } from "@sap-devx/app-studio-toolkit-types"; | ||
| import { ICommandAction, IExecuteAction, IFileAction, ISnippetAction, bas, IAction, ActionType, BasAction } from "@sap-devx/app-studio-toolkit-types"; |
Member
|
See inline comments |
Member
|
Is this a
your case is a |
bd82
reviewed
Jun 13, 2021
| } | ||
| break; | ||
| case ActionType.File: | ||
| case "FILE": |
Member
There was a problem hiding this comment.
do we need to handle "URI" here as well?
If our consumers have such switch-cases could not we break them by adding the new "URI" value?
bd82
reviewed
Jun 13, 2021
| console.log(`Mock executing command ${commandAction.name}`); | ||
| break; | ||
| case ActionType.File: | ||
| case "FILE": |
Member
There was a problem hiding this comment.
do we need to handle "URI" as well?
bd82
approved these changes
Jun 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.