Skip to content

chore - change nx config for platform specific caching #2996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
devinea merged 18 commits into from
May 21, 2025
Merged

chore - change nx config for platform specific caching #2996

devinea merged 18 commits into from
May 21, 2025

Conversation

@devinea
Copy link
Member

@devinea devinea commented Mar 5, 2025 •
edited
Loading

  • Upgrade Nx
  • used sharedGlobals to make the nx cache unique across OS and NodeJS matrix
  • fixes

@changeset-bot
Copy link

changeset-bot bot commented Mar 5, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 842fd3c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 5, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

devinea added 8 commits May 19, 2025 19:56
@devinea
Merge remote-tracking branch 'origin/main' into nx_cache_changes
27781b5 
* origin/main: (316 commits)
  chore: apply latest changesets
  feat(ui-components) export pivot (#3250)
  Update SVG of modules on readme.md showing open source modules and dependencies (#3245)
  chore: apply latest changesets
  feat: Move the cards-editor-middleware code to preview-middleware (#3167)
  chore: apply latest changesets
  fix: added apptype to quickactions and contextmenu (#3203)
  chore: apply latest changesets
  feat: Integration of ExtendControllerPlugin in Adaptation Editor (#3075)
  chore: apply latest changesets
  feat: Update of backend (#3226)
  tbi(fiori-gen): updates for ui5 app inquirer options (#3235)
  chore: apply latest changesets
  chore - drop node18 support as it is out of maintenance (#3243)
  chore: apply latest changesets
  fix: new cds parser support (#3242)
  chore: apply latest changesets
  feat: Improve ADP generator writer by refactoring its logic (#3234)
  chore: apply latest changesets
  fix(ui-service-gen): use namespace for transports and service path (#3236)
  ...
@devinea
WIP
5bfc54c
@devinea
WIP
6e005dd
@devinea
revert parallel
6cce677
@devinea
WIP
d94753b
@devinea
revert
f533aca
@devinea
Merge remote-tracking branch 'origin/main' into nx_cache_changes
6f47564 
* origin/main:
  chore: apply latest changesets
  fix(fe-writer): fix html target for opa tests when using virtual endpoints (#3252)
  chore: apply latest changesets
  fix(preview-middleware) fix template spacing (#3253)
@devinea
change resolve to join fix failing test on windows
57b0f06
@devinea devinea changed the title change nx config chore - change nx config for platform specific caching May 20, 2025
@devinea devinea marked this pull request as ready for review May 20, 2025 16:56
@devinea devinea requested review from a team as code owners May 20, 2025 16:56
IainSAP
IainSAP approved these changes May 20, 2025
View reviewed changes
Copy link
Contributor

@IainSAP IainSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @devinea

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 20, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Klaus-Keller
Klaus-Keller approved these changes May 20, 2025
View reviewed changes
Copy link
Contributor

@Klaus-Keller Klaus-Keller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @devinea, changes for nx cache seem to work fine and fix the issue.

nlunets
nlunets approved these changes May 21, 2025
View reviewed changes
Copy link
Member

@nlunets nlunets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good

@devinea devinea merged commit 31d687c into main May 21, 2025
16 checks passed
@devinea devinea deleted the nx_cache_changes branch May 21, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nlunets nlunets nlunets approved these changes

@IainSAP IainSAP IainSAP approved these changes

@Klaus-Keller Klaus-Keller Klaus-Keller approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@devinea @nlunets @IainSAP @Klaus-Keller