fix: reuse component detection #3038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 32ed9bb The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
voicis
reviewed
Mar 24, 2025
packages/preview-middleware-client/src/cpe/quick-actions/quick-action-definition.ts
Outdated
Show resolved
Hide resolved
lfindlaysap
requested changes
Mar 25, 2025
Contributor
lfindlaysap
left a comment
lfindlaysap
left a comment
There was a problem hiding this comment.
@mmilko01, some questions and suggestions.
packages/preview-middleware-client/src/messagebundle.properties
Outdated
Show resolved
Hide resolved
packages/preview-middleware-client/src/messagebundle.properties
Outdated
Show resolved
Hide resolved
packages/preview-middleware-client/src/messagebundle.properties
Outdated
Show resolved
Hide resolved
packages/preview-middleware-client/src/messagebundle.properties
Outdated
Show resolved
Hide resolved
packages/preview-middleware-client/src/messagebundle.properties
Outdated
Show resolved
Hide resolved
packages/preview-middleware-client/src/messagebundle.properties
Outdated
Show resolved
Hide resolved
packages/preview-middleware-client/src/messagebundle.properties
Outdated
Show resolved
Hide resolved
GDamyanov
previously approved these changes
Mar 25, 2025
Contributor
GDamyanov
left a comment
GDamyanov
left a comment
There was a problem hiding this comment.
Code looks good.
Excellent test coverage.
Did not tested manually.
lfindlaysap
requested changes
Mar 26, 2025
Contributor
lfindlaysap
left a comment
lfindlaysap
left a comment
There was a problem hiding this comment.
@mmilko01, thanks for the clarification. I've added my suggestions below.
packages/preview-middleware-client/src/messagebundle.properties
Outdated
Show resolved
Hide resolved
packages/preview-middleware-client/src/messagebundle.properties
Outdated
Show resolved
Hide resolved
packages/preview-middleware-client/src/messagebundle.properties
Outdated
Show resolved
Hide resolved
packages/preview-middleware-client/src/messagebundle.properties
Outdated
Show resolved
Hide resolved
lfindlaysap
reviewed
Mar 26, 2025
Contributor
lfindlaysap
left a comment
lfindlaysap
left a comment
There was a problem hiding this comment.
@mmilko01, I've aligned with @JannaLisa and provided the following comments.
packages/preview-middleware-client/src/messagebundle.properties
Outdated
Show resolved
Hide resolved
…P/open-ux-tools into fix/reuse-component-detection
lfindlaysap
previously approved these changes
Mar 26, 2025
Contributor
lfindlaysap
left a comment
lfindlaysap
left a comment
There was a problem hiding this comment.
@mmilko01, awesome :)
voicis
previously approved these changes
Mar 27, 2025
Contributor
voicis
left a comment
voicis
left a comment
There was a problem hiding this comment.
- Code changes looks good
- Review comments addressed
- Good test coverage
- Did not test manually
|
voicis
approved these changes
Apr 2, 2025
lfindlaysap
approved these changes
Apr 2, 2025
devinea
added a commit
that referenced
this pull request
Apr 2, 2025
* origin/main: (38 commits) chore: apply latest changesets fix: Cannot create a Fragment and Controller Extension when clicking create button in the dialog (#3079) fix: revert test folder from eslintignore (#3071) chore: apply latest changesets fix(cf-deploy-config-writer): update the mta post install script (#3076) chore: apply latest changesets fix(cf-deploy-config-sub-generator): ensure completion message is shown to user (#3070) chore: apply latest changesets fix: reuse component detection (#3038) chore: apply latest changesets fix(abap-inq):init transport config for scp systems (#3068) chore: apply latest changesets fix(odata-inq): prevent changing service path casing (#3067) chore: apply latest changesets fix: call `initTheme` API method to initialize theme for `ui-components` (#3062) chore: apply latest changesets fix (ui-components): standardize SwitchOff and SwitchOn icons to 16x16 (#3061) chore: apply latest changesets fix(ui-components): Remove font-family definitions from individual components and apply it globally. (#3060) chore: apply latest changesets ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3045
isReuseComponentAPI from RTA to detect reuse components.Add: FragmentandExtend with Controlleron control level only