Skip to content

Conversation

@ytpo-lyne
Copy link
Contributor

Supports the pathReplace over the ui5-proxy-middleware in order to allow ui5.yaml configurations to load UI5 from a different resource path that is not e.g. /1.96.25/resources by default.

@ytpo-lyne ytpo-lyne requested a review from heimwege September 25, 2025 08:12
@ytpo-lyne ytpo-lyne added the ui5-proxy-middleware @sap-ux/ui5-proxy-middleware label Sep 25, 2025
@changeset-bot
Copy link

changeset-bot bot commented Sep 25, 2025

🦋 Changeset detected

Latest commit: 0a362fe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sap-ux/ui5-proxy-middleware Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ytpo-lyne ytpo-lyne marked this pull request as ready for review October 1, 2025 10:18
@ytpo-lyne ytpo-lyne requested a review from a team as a code owner October 1, 2025 10:18
Copy link
Contributor

@longieirl longieirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changeset is good.
A locally built version consuming these changes was validated on BAS and working as expected.
Tests are good.
Overall changes look good.

Copy link
Contributor

@heimwege heimwege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • changeset ok
  • code coverage is excellent
  • changes are straightforward
  • did NOT test manually

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 1, 2025

@ytpo-lyne ytpo-lyne merged commit d9acb53 into main Oct 1, 2025
21 of 24 checks passed
@ytpo-lyne ytpo-lyne deleted the fix/ui5-proxy-middleware/pathRewrite branch October 1, 2025 14:55
devinea added a commit that referenced this pull request Oct 2, 2025
…sults

* origin/main:
  chore: apply latest changesets
  fix(ui5-proxy-middleware): support pathRewrite for UI5 resources  (#3669)
  chore: apply latest changesets
  fix: Wrong navigation between steps in FLP Configuration generator for ADP (#3691)
  Update Icons for Page and Building Block (#3690)
  chore: apply latest changesets
  fix: "lrep" property is not added when the deploy config is created from within the ADP Generator (#3687)
devinea added a commit that referenced this pull request Oct 3, 2025
* origin/main: (243 commits)
  chore: apply latest changesets
  fix(ui5 library inquirer): 32726 versions sapui5 distribution metadata (#3666)
  chore: apply latest changesets
  fix: Missing build script for ADP onPremise projects leads to error during deployment (#3695)
  chore: apply latest changesets
  fix(ui5-proxy-middleware): support pathRewrite for UI5 resources  (#3669)
  chore: apply latest changesets
  fix: Wrong navigation between steps in FLP Configuration generator for ADP (#3691)
  Update Icons for Page and Building Block (#3690)
  chore: apply latest changesets
  fix: "lrep" property is not added when the deploy config is created from within the ADP Generator (#3687)
  chore: apply latest changesets
  feat(proxy-middleware): http-proxy-middleware v3 migration (#3032)
  chore: apply latest changesets
  fix(ui-service-gen): escape information message (#3681)
  Project modules update 30.09.2025 (4843) (#3684)
  chore: apply latest changesets
  feat: use schema approach for input parameters in functionality details (#3673)
  chore: apply latest changesets
  Remove button group configuration from Rich Text Editor template for initial version (#3678)
  ...
tom-sap added a commit that referenced this pull request Oct 16, 2025
* main:
  chore: apply latest changesets
  fix(ui5-proxy-middleware): support pathRewrite for UI5 resources  (#3669)
  chore: apply latest changesets
  fix: Wrong navigation between steps in FLP Configuration generator for ADP (#3691)
  Update Icons for Page and Building Block (#3690)
  chore: apply latest changesets
  fix: "lrep" property is not added when the deploy config is created from within the ADP Generator (#3687)
  chore: apply latest changesets
  feat(proxy-middleware): http-proxy-middleware v3 migration (#3032)
  chore: apply latest changesets
  fix(ui-service-gen): escape information message (#3681)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ui5-proxy-middleware @sap-ux/ui5-proxy-middleware

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants