-
Notifications
You must be signed in to change notification settings - Fork 53
fix(ui5-proxy-middleware): support pathRewrite for UI5 resources #3669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 0a362fe The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
….com/SAP/open-ux-tools into fix/ui5-proxy-middleware/pathRewrite
longieirl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changeset is good.
A locally built version consuming these changes was validated on BAS and working as expected.
Tests are good.
Overall changes look good.
heimwege
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- changeset ok
- code coverage is excellent
- changes are straightforward
- did NOT test manually
|
…sults * origin/main: chore: apply latest changesets fix(ui5-proxy-middleware): support pathRewrite for UI5 resources (#3669) chore: apply latest changesets fix: Wrong navigation between steps in FLP Configuration generator for ADP (#3691) Update Icons for Page and Building Block (#3690) chore: apply latest changesets fix: "lrep" property is not added when the deploy config is created from within the ADP Generator (#3687)
* origin/main: (243 commits) chore: apply latest changesets fix(ui5 library inquirer): 32726 versions sapui5 distribution metadata (#3666) chore: apply latest changesets fix: Missing build script for ADP onPremise projects leads to error during deployment (#3695) chore: apply latest changesets fix(ui5-proxy-middleware): support pathRewrite for UI5 resources (#3669) chore: apply latest changesets fix: Wrong navigation between steps in FLP Configuration generator for ADP (#3691) Update Icons for Page and Building Block (#3690) chore: apply latest changesets fix: "lrep" property is not added when the deploy config is created from within the ADP Generator (#3687) chore: apply latest changesets feat(proxy-middleware): http-proxy-middleware v3 migration (#3032) chore: apply latest changesets fix(ui-service-gen): escape information message (#3681) Project modules update 30.09.2025 (4843) (#3684) chore: apply latest changesets feat: use schema approach for input parameters in functionality details (#3673) chore: apply latest changesets Remove button group configuration from Rich Text Editor template for initial version (#3678) ...
* main: chore: apply latest changesets fix(ui5-proxy-middleware): support pathRewrite for UI5 resources (#3669) chore: apply latest changesets fix: Wrong navigation between steps in FLP Configuration generator for ADP (#3691) Update Icons for Page and Building Block (#3690) chore: apply latest changesets fix: "lrep" property is not added when the deploy config is created from within the ADP Generator (#3687) chore: apply latest changesets feat(proxy-middleware): http-proxy-middleware v3 migration (#3032) chore: apply latest changesets fix(ui-service-gen): escape information message (#3681)



Supports the pathReplace over the ui5-proxy-middleware in order to allow ui5.yaml configurations to load UI5 from a different resource path that is not e.g.
/1.96.25/resourcesby default.