Foxhound: remove native_ property from TaintOperation#360
Merged
Conversation
The native_ flag (and associated isNative()/setNative() API) was used to distinguish built-in JS functions from user-defined ones, but this distinction is not needed for taint tracking. Remove the flag, all constructor overloads that accepted it, and the 'builtin' property it exposed to JavaScript.
|
|
Collaborator
Author
|
Merging this would require cooperation with the ZAP addon and the extensions. |
tmbrbr
approved these changes
Mar 17, 2026
leeN
added
enhancement
Collaborator
Author
|
Okay, the currently blessed extension does not seem to access the native property and neither does the Zap Addon. So we should be good to merge, the only code using it is the old hand sanitizer flow_analyzer, but that is not something that works with modern Foxhound to begin with. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The native_ flag (and associated isNative()/setNative() API) was used to distinguish built-in JS functions from user-defined ones, but this distinction is not needed for taint tracking. Remove the flag, all constructor overloads that accepted it, and the 'builtin' property it exposed to JavaScript.