feat: create new module for bas extension #544
Conversation
| console.log("Copying finished successfully"); | ||
|
|
||
| const vsixFiles = []; | ||
| readdirSync(getBaseSrc()).forEach((item) => { |
There was a problem hiding this comment.
If you are going to copy only one file
Why do you scan and collect all *.vsix file names?
And in this case should not it be an error if multiple *.vsix files are found?
There was a problem hiding this comment.
because file name e.g vscode-ui5-language-assistant-3.3.1.vsix is not clear und therefore checks base folder to get one.
Regarding multiple vsix files, it is usually never the case on CI, but anyway I adapted logic which throws an error in case of multiple or when found not vsix file.
bd82
left a comment
bd82
left a comment
There was a problem hiding this comment.
metadata (package.json) of this new package needs more cleaning imho.
also please define a .gitignore in this new package so copied artifacts (*.vsix)
will not make changes in git working tree.
| ); | ||
| } | ||
| const vsixFile = vsixFiles.pop(); | ||
| if (!vsixFile) { |
There was a problem hiding this comment.
you can probably combine these two checks with vsixFiles.length === 1
But this is not mandatory...
Create a simple bas extension. Required data can be seen here. These data will be copied over when
yarn cicommand is executedNote: This will be the only public module on https://www.npmjs.com/