Skip to content

Conversation

@roeeyn
Copy link
Contributor

@roeeyn roeeyn commented Mar 6, 2025

Pull Request Template

Description

The typing for the recover_comprobante_request function is wrong. Multiple fields have None as default value, but the type doesn't include the None type. This PR fixes that.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Linter doesn't complain anymore about this issue

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@satcfdi
Copy link
Member

satcfdi commented Apr 7, 2025

Se ve bien

@satcfdi satcfdi self-requested a review April 7, 2025 18:03
Copy link
Member

@satcfdi satcfdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@satcfdi satcfdi merged commit dc1d976 into SAT-CFDI:main Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants