This repository was archived by the owner on Apr 1, 2026. It is now read-only.
fix gcc15 issues#10
Merged
JaceCear merged 4 commits intoSAT-R:mainfrom Nov 18, 2025
Merged
Conversation
JaceCear
reviewed
Nov 9, 2025
| CC1FLAGS += -Wstrict-overflow=1 | ||
| ifeq ($(PLATFORM),sdl) | ||
| CC1FLAGS += -Wno-parentheses-equality -Wno-unused-value | ||
| CC1FLAGS += -Wno-parentheses-equality -Wno-unused-value -Wno-incompatible-pointer-types |
Collaborator
There was a problem hiding this comment.
This warning should not be removed, I think.
Collaborator
There was a problem hiding this comment.
include/lib/m4a/m4a_internal.h:extern MPlayFunc gMPlayJumpTable[];
is
include/lib/m4a/m4a_internal.h:extern void *gMPlayJumpTable[];
in SA2, feel free to adjust that.
As well as
src/lib/m4a/m4a.c:EWRAM_DATA void *gMPlayJumpTable[36] = {};
742e127 to
3dcc241
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds two flags (
-std=c11and-Wno-incompatible-pointer-types)' to prevent compiler errors on gcc 15(this one is sdl exclusive)