Skip to content

Named Player_8013E34#229

Merged
JaceCear merged 2 commits intoSAT-R:mainfrom
TsukiruP:main
Nov 16, 2025
Merged

Named Player_8013E34#229
JaceCear merged 2 commits intoSAT-R:mainfrom
TsukiruP:main

Conversation

@TsukiruP
Copy link
Contributor

No description provided.

@freshollie
Copy link
Collaborator

Anything else you wanna do on this? I can merge otherwise

@TsukiruP
Copy link
Contributor Author

TsukiruP commented Nov 13, 2025

Yeah, actually. sub_8012DF8 is specific for Knuckles' Drill Claw and Spiral attack in boost mode. I'll handle those later.
Edit: Noticed more similar unnamed tasks like sub_8012DF8 or those that could be renamed like Player_Sonic_Bound and Player_SonicAmy_InitSkidAttackGfxTask.

* Renamed Player_SonicAmy_InitSkidAttackGfxTask to CreateSonicAmySkidAttackEffect.
* Renamed Player_Sonic_Bound to CreateSonicBoundEffect.
* Named sub_80129DC as CreateTailsTailSwipeEffect.
* Named sub_8012DF8 as CreateKnucklesFireEffect.
@TsukiruP
Copy link
Contributor Author

Finished what I wanted to do for the meantime

Copy link
Collaborator

@JaceCear JaceCear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@JaceCear JaceCear merged commit 981955e into SAT-R:main Nov 16, 2025
20 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants