Match SA1's CreateStageUI & CreateSpecialStageUI#270
Merged
Conversation
now we only need to figure out StageUI_DrawTimer and sub_8053BAC, horray!
delete the target asm file, since, apparently, web github can't do multiple stuff at a single commit, for some reason
hopefully, we find a way to make proper use of the original code's (possible) debug behavior... or i could be exaggerating over what was originally just the devs playing safe! eh, either theory works, i guess
Collaborator
|
Thank you @SketchyGear! You can remove the NON_MATCHING directives, though. (also the "why would anyone..." comment) That'll likely be optimized out without manual intervention. But it is a good preventative measure to have them, in case someone tried using the Task pointer before proper initialization, and there's no need to split the logic off like that. |
revert the previous commit, basically (web GitHub also doesn't support commit reverting, what a surprise!)
Contributor
Author
|
there you go! i guess i really exaggerated a bit when i originally committed that, lol |
JaceCear
reviewed
May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Matching versions of Advance 1's
stage_uifunctions: