Skip to content

cetmodules migration #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
miquelnebot merged 24 commits into from
Nov 11, 2022
Merged

cetmodules migration #471

miquelnebot merged 24 commits into from
Nov 11, 2022

Conversation

@gartung
Copy link
Contributor

@gartung gartung commented Oct 19, 2022 •
edited
Loading

Proposed changes to CMakeLists.txt for migration to cetmodules.

@rennney
Copy link
Contributor

rennney commented Oct 19, 2022

trigger build

@FNALbuild
Copy link
Collaborator

FNALbuild commented Oct 19, 2022

✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Oct 19, 2022

✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Oct 19, 2022

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e20:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Oct 19, 2022

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c7:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@mmrosenberg
Copy link
Contributor

mmrosenberg commented Oct 21, 2022

trigger build

@FNALbuild
Copy link
Collaborator

FNALbuild commented Oct 21, 2022

✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Oct 21, 2022

✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Oct 21, 2022

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c7:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Oct 21, 2022

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e20:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@mmrosenberg
Copy link
Contributor

mmrosenberg commented Oct 22, 2022

trigger build

@FNALbuild
Copy link
Collaborator

FNALbuild commented Oct 22, 2022

✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Oct 22, 2022

✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Oct 22, 2022

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for c7:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Oct 22, 2022

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for e20:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@gartung
Copy link
Contributor Author

gartung commented Oct 22, 2022 •
edited
Loading

The cmake warnings are from the use of deprecated cet cmake macros. For a complete migration more changes will be needed.

@gartung gartung mentioned this pull request Oct 24, 2022
Merged
@FNALbuild
Copy link
Collaborator

FNALbuild commented Oct 28, 2022

✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Oct 28, 2022

✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Oct 28, 2022

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c7:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Oct 28, 2022

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e20:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Nov 4, 2022

❌ CI build for ICARUS Failed at phase ci_tests ICARUS on slf7 for c7:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@greenc-FNAL
Copy link

greenc-FNAL commented Nov 4, 2022

@gartung, please address remaining (unresolved) review comments with question marks, and see if the FFTW3-related recommendations can be implemented easily.

@gartung
Copy link
Contributor Author

gartung commented Nov 4, 2022

trigger build SBNSoftware/icarusalg#62 SBNSoftware/icarus_signal_processing#10

@FNALbuild
Copy link
Collaborator

FNALbuild commented Nov 4, 2022

✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Nov 4, 2022

✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Nov 4, 2022

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for c7:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Nov 4, 2022

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for e20:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@gartung
Copy link
Contributor Author

gartung commented Nov 10, 2022

trigger build

@gartung
Copy link
Contributor Author

gartung commented Nov 10, 2022

trigger build SBNSoftware/icarusalg#62 SBNSoftware/icarus_signal_processing#10

@FNALbuild
Copy link
Collaborator

FNALbuild commented Nov 10, 2022

✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Nov 10, 2022

✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Nov 10, 2022

✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Nov 10, 2022

✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard

@miquelnebot
Copy link
Contributor

miquelnebot commented Nov 10, 2022

trying to centralise the discussion somewhere
@gartung, @rennney has createad this brachens with the current errors for for icaruscode, icarusalg, and icarus_signal_processing
release/test_release_cetmodules
could you try to build it to reproduce the errors?

@gartung
Copy link
Contributor Author

gartung commented Nov 10, 2022

I saw the error earlier after I merged release/test_release_cetmodules into from-v09_60_01. I found the issues and fixed them. merge in the current head of from-v09_60_01 into release/test_release_cetmodules.

@FNALbuild
Copy link
Collaborator

FNALbuild commented Nov 10, 2022

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for e20:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Nov 10, 2022

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for c7:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@rennney
Copy link
Contributor

rennney commented Nov 10, 2022

iacruscode v09_62_00_02 that includes current develop+this PR is now on cvmfs. Same for icarusalg and icarus_signal_processing

@FNALbuild
Copy link
Collaborator

FNALbuild commented Nov 10, 2022

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for c7:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Collaborator

FNALbuild commented Nov 10, 2022

⚠️ CI build for ICARUS Warning at phase ci_tests ICARUS on slf7 for e20:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests ICARUS phase logs

parent CI build details are available through the CI dashboard

@miquelnebot miquelnebot merged commit e2b7dbe into SBNSoftware:develop Nov 11, 2022
@gartung gartung deleted the from-v09_60_01 branch November 14, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greenc-FNAL greenc-FNAL greenc-FNAL requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@gartung @rennney @FNALbuild @mmrosenberg @greenc-FNAL @miquelnebot