Skip to content

Conversation

@jas1005
Copy link
Contributor

@jas1005 jas1005 commented Jan 20, 2026

Master acts as a proxy for develop. Update master to be current with develop by including PRs #836 and #874.

Copilot AI review requested due to automatic review settings January 20, 2026 21:40
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request merges PRs #836 and #874 from develop into master, updating CI test configurations and simulation/reconstruction FCL files to use standardized configuration files, along with a patch version bump.

Changes:

  • Updated multiple CI test configuration files to reference new standardized FCL includes
  • Modified g4 simulation configurations to add energy deposit instance labels and skip track ID offsets
  • Created a new Stage0 configuration file for dropping daqPMT data and removed daqPMT drop commands from stage0_run2 files
  • Bumped version string from 10.06.00.01-p03 to 10.06.00.01-p03b

Reviewed changes

Copilot reviewed 23 out of 23 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
test/ci/icarus_ci_single_reco1_quick_test_icaruscode.fcl Updated include to use standard_mc_all_stage1_icarus.fcl
test/ci/icarus_ci_single_reco0_quick_test_icaruscode.fcl Updated include to use standard_mc_all_stage0_icarus.fcl
test/ci/icarus_ci_single_g4_quick_test_icaruscode.fcl Updated include to use standard_mc_beamcosmics_g4_icarus.fcl
test/ci/icarus_ci_single_detsim_quick_test_icaruscode.fcl Updated include to use standard_mc_all_detsim_icarus.fcl
test/ci/icarus_ci_nucosmics_reco1_quick_test_icaruscode.fcl Updated include to use standard_mc_all_stage1_icarus.fcl
test/ci/icarus_ci_nucosmics_reco0_quick_test_icaruscode.fcl Updated include to use standard_mc_all_stage0_icarus.fcl
test/ci/icarus_ci_nucosmics_gen_quick_test_icaruscode.fcl Updated includes, CORSIKA paths, and changed to proton-only configuration
test/ci/icarus_ci_nucosmics_g4_quick_test_icaruscode.fcl Updated include to use standard_mc_beamcosmics_g4_icarus.fcl
test/ci/icarus_ci_nucosmics_detsim_quick_test_icaruscode.fcl Updated include to use standard_mc_all_detsim_icarus.fcl
test/ci/icarus_ci_intimecosmic_reco1_quick_test_icaruscode.fcl Updated include and added MCParticle configuration with log silencing
test/ci/icarus_ci_intimecosmic_reco0_quick_test_icaruscode.fcl Updated include to use standard_mc_all_stage0_icarus.fcl
test/ci/icarus_ci_intimecosmic_gen_quick_test_icaruscode.fcl Updated include to use new prodcorsika configuration file
test/ci/icarus_ci_intimecosmic_g4_quick_test_icaruscode.fcl Updated include to use standard_mc_intime_g4_icarus.fcl
test/ci/icarus_ci_intimecosmic_detsim_quick_test_icaruscode.fcl Updated include to use standard_mc_all_detsim_icarus.fcl
fcl/standard/standard_mc_all_detsim_icarus.fcl Updated to include refactored yzsim configuration
fcl/reco/Stage1/mc/stage1_run2_icarus_MC_intime.fcl New file created for intime MC reconstruction with dropped MCParticle configuration
fcl/reco/Stage0/data/stage0_run2_wc_icarus.fcl Removed daqPMT drop command from output
fcl/reco/Stage0/data/stage0_run2_icarus.fcl Removed daqPMT drop command from output
fcl/reco/Stage0/data/stage0_daqPMT_drop.fcl New file created for dropping daqPMT data in post-processing
fcl/g4/larg4_icarus_intime_sce.fcl Added EnergyDepositInstanceLabels configuration for priorSCE
fcl/g4/larg4_icarus_intime.fcl Added SkipTrackIDOffsets erase directive
fcl/g4/2d_drift_sim/larg4_icarus_intime_sce_2d_drift.fcl Added EnergyDepositInstanceLabels configuration for priorSCE
CMakeLists.txt Updated version string to 10.06.00.01-p03b

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


physics.producers.mcreco.MCParticleDroppedLabel: "largeantdropped"

# silence SimDriftElectrons warnings, for 1 event these crerate a 900MB log file.
Copy link

Copilot AI Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a spelling error in the comment. "crerate" should be "create".

Suggested change
# silence SimDriftElectrons warnings, for 1 event these crerate a 900MB log file.
# silence SimDriftElectrons warnings, for 1 event these create a 900MB log file.

Copilot uses AI. Check for mistakes.
# "/cvmfs/sbn.osgstorage.org/pnfs/fnal.gov/usr/sbn/persistent/stash/physics/cosmics/Fermilab/CORSIKA/standard/N_showers_*.db",
# "/cvmfs/sbn.osgstorage.org/pnfs/fnal.gov/usr/sbn/persistent/stash/physics/cosmics/Fermilab/CORSIKA/standard/Mg_showers_*.db",
# "/cvmfs/sbn.osgstorage.org/pnfs/fnal.gov/usr/sbn/persistent/stash/physics/cosmics/Fermilab/CORSIKA/standard/Fe_showers_*.db"
#]
Copy link

Copilot AI Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment at line 27 has a stray "#]" that creates an inconsistency. This line should be removed or the closing bracket should be properly aligned with the opening bracket on line 21. Currently, the array is properly closed on line 21, making line 27 redundant and potentially confusing.

Suggested change
#]

Copilot uses AI. Check for mistakes.
@jas1005 jas1005 merged commit 378b1bf into master Jan 20, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants