[private] consolidating pmt updates from feature/gp_overlayFix#901
Merged
mvicenzi merged 22 commits intoMay 18, 2026
Merged
Conversation
Added also a configuration item specifying its Run3 and default value.
Also reveals a bug in TableAs, which needs a wordy workaround.
* debug tree branch variables isolated from the rest of the member variables * merged the SimPhotons and SimPhotonsLite loops to avoid code duplication (in a way preserving the interface with PMTsimulationAlg)
…t baseline Rounding changed from truncation to nearest integer. Removed the workaround, made obsolete, of setting the baseline to 14999.5: now it is back to the intended 15000.
Removed unused parts, adhered to standards. No actual change.
Replaces the functionality of the "generalist" OverlayProducts module (which has overlapping detection broken and hard-coded simulation baselines, things that can be in principle fixed). This module does the minimum it has to in order to make the overlay workflow work and flow. Overlay job configuration is changed to adopt it.
A new configuration of DetectorClocksService is introduced for simulation workflows. A drop-in override is provided (`override_services_for_simulation.fcl`). Stage0, Stage1, CAF and overlay configurations are updated to use it.
Includes the change of discrimination threshold from Run1 (400 ADC#) to Run2 standard (390 ADC#) and internal adjustments.
Enabled by the change in PMTsimulationAlg that produces the baselines.
… gate time In the plain simulation, defined as the one performed with standard DetectorClocks configuration, simulation time and beam time scales coincide. Introducing a time scale shift in the workflow, we redefine the beam gate time, adding a margin before the beam, which separates the two scales. The beam gate produced at generation stage refers to simulation time, as all the gates derived by it do.
The beam gate start time in raw::Trigger et al. assumed the input gate to be in the (current) beam gate time scale, but that may be not true. The gate is always output in electronics time anyway.
This accounts for the average time it takes the hardware trigger to emit a response. Beam gates may need to be corrected accordingly, as the beam gate start time is not subject to this delay. The delay is encoded in the configurations for Run2. The value, obtained by visual calibration, is statistically compatible with the one from Run3.
It is now the same for simulation as it is for data.
* added `--suffix` and `--and` options * explicit support for compressed raw data, "raw" became uncompressed only
…ure/gp_overlayFix
mvicenzi
added
the
private
mvicenzi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.