-
Notifications
You must be signed in to change notification settings - Fork 35
New track calo skimmer module for ICARUS calibration stuff. #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
wesketchum
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Larger suggestions:
- not clear if the tool is very ICARUS focused or not, but if it is could name it "ICARUS" somehow to not worry as much about use in SBND.
- I'm a little worried that the HitInfo object use may just bloat memory. Do you have any memory usage stats for this module from the memory tracker?
- Has this been checked on ICARUS data, with both west and east cryostats? If not, strongly suggest that is done before this is merged in.
sbncode/Calibration/TrackCaloSkimmerSelectStoppingTrack_tool.cc
Outdated
Show resolved
Hide resolved
sbncode/Calibration/TrackCaloSkimmerSelectStoppingTrack_tool.cc
Outdated
Show resolved
Hide resolved
sbncode/Calibration/TrackCaloSkimmerSelectStoppingTrack_tool.cc
Outdated
Show resolved
Hide resolved
sbncode/Calibration/TrackCaloSkimmerSelectStoppingTrack_tool.cc
Outdated
Show resolved
Hide resolved
I've addressed the first round of comments! On these points -- I thought we wanted it usable in SBND? In any case, I've added a comment to specify its origin in ICARUS. The memory footprint of this module is not significant compared to the stage0/stage1 processing. Just did a test which returned <2GB of memory. And yes, it has been run in both cryostats on a large number of ICARUS data events. |
|
Thanks Gray! Resolved most, added a few comments. On the bigger ones, that all sounds good, just wanted to be sure. |
…o separate WireInfo object.
…hroughgoing tracks. Implement inversion and pre-scale in selection tool base class.
…k config to not do any prescale.
|
trigger build SBNSoftware/sbnobj#17 |
|
CI build for LArSoft on slf7 for e20:prof is in progress -- details available through the CI dashboard |
|
CI build for LArSoft on slf7 for c7:prof is in progress -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard |
|
CI build for SBND on slf7 for c7:prof is in progress -- details available through the CI dashboard parent CI build details are available through the CI dashboard |
|
CI build for ICARUS on slf7 for c7:prof is in progress -- details available through the CI dashboard parent CI build details are available through the CI dashboard |
|
CI build for SBND on slf7 for e20:prof is in progress -- details available through the CI dashboard parent CI build details are available through the CI dashboard |
|
CI build for ICARUS on slf7 for e20:prof is in progress -- details available through the CI dashboard parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c7:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e20:prof -- details available through the CI dashboard 🚨 For more details about the failed phase, check the build ICARUS phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
|
🚨 For more details about the warning phase, check the ci_tests SBND phase logs parent CI build details are available through the CI dashboard |
New module. Orthogonal to existing stuff. Depends on SBNSoftware/sbnobj#17.