Skip to content

Conversation

@gputnam
Copy link
Contributor

@gputnam gputnam commented Jun 17, 2021

New module. Orthogonal to existing stuff. Depends on SBNSoftware/sbnobj#17.

Copy link
Contributor

@wesketchum wesketchum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Larger suggestions:

  • not clear if the tool is very ICARUS focused or not, but if it is could name it "ICARUS" somehow to not worry as much about use in SBND.
  • I'm a little worried that the HitInfo object use may just bloat memory. Do you have any memory usage stats for this module from the memory tracker?
  • Has this been checked on ICARUS data, with both west and east cryostats? If not, strongly suggest that is done before this is merged in.

@gputnam
Copy link
Contributor Author

gputnam commented Jun 18, 2021

Larger suggestions:

* not clear if the tool is very ICARUS focused or not, but if it is could name it "ICARUS" somehow to not worry as much about use in SBND.

* I'm a little worried that the HitInfo object use may just bloat memory. Do you have any memory usage stats for this module from the memory tracker?

* Has this been checked on ICARUS data, with both west and east cryostats? If not, strongly suggest that is done before this is merged in.

I've addressed the first round of comments! On these points -- I thought we wanted it usable in SBND? In any case, I've added a comment to specify its origin in ICARUS.

The memory footprint of this module is not significant compared to the stage0/stage1 processing. Just did a test which returned <2GB of memory.

And yes, it has been run in both cryostats on a large number of ICARUS data events.

@wesketchum
Copy link
Contributor

Thanks Gray! Resolved most, added a few comments. On the bigger ones, that all sounds good, just wanted to be sure.

@miquelnebot
Copy link
Contributor

trigger build SBNSoftware/sbnobj#17

@FNALbuild
Copy link

CI build for LArSoft on slf7 for e20:prof is in progress -- details available through the CI dashboard

@FNALbuild
Copy link

CI build for LArSoft on slf7 for c7:prof is in progress -- details available through the CI dashboard

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for c7:prof -- details available through the CI dashboard

@FNALbuild
Copy link

✔️ CI build for LArSoft Succeeded on slf7 for e20:prof -- details available through the CI dashboard

@FNALbuild
Copy link

CI build for SBND on slf7 for c7:prof is in progress -- details available through the CI dashboard

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

CI build for ICARUS on slf7 for c7:prof is in progress -- details available through the CI dashboard

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

CI build for SBND on slf7 for e20:prof is in progress -- details available through the CI dashboard

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

CI build for ICARUS on slf7 for e20:prof is in progress -- details available through the CI dashboard

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for c7:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

❌ CI build for ICARUS Failed at phase build ICARUS on slf7 for e20:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build ICARUS phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for c7:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e20:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@miquelnebot miquelnebot added the enhancement New feature or request label Jun 30, 2021
@miquelnebot miquelnebot merged commit ef2b1fa into develop Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants