Skip to content

Changing detsim drops for detvars#783

Merged
nathanielerowe merged 10 commits intodevelopfrom
Bugfix/linyan-keepdetsim
Sep 16, 2025
Merged

Changing detsim drops for detvars#783
nathanielerowe merged 10 commits intodevelopfrom
Bugfix/linyan-keepdetsim

Conversation

@linyan-w
Copy link
Copy Markdown
Contributor

@linyan-w linyan-w commented Aug 11, 2025

Description

This is a PR into develop for fall production.

  • Keeping sim::SimPhotonsLites for PDS detvar samples (boost reco1 file size by 1%)
    • workflow: scrub opdaq from detsim, rerun opdaq only detsim
  • Keeping SimEnergyDeposits_PriorSCE_G4 (boost reco1 file size by > 30%)
    • originally planned just for the 1xdata stat CV MC sample that detvar samples will scrub from
    • realized that we need it for wiremod and thus modifying the default drop

Checklist

  • Added at least 1 label from available labels.
  • Assigned at least 1 reviewer under Reviewers,
  • Assigned all contributers including yourself under Assignees
  • Linked any relevant issues under Developement
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
  • Does this affect the standard workflow?
  • Is this PR a patch for the ongoing production? If so, separate PR must also be made for production/v10_06_00 branch!

Relevant PR links (optional)

Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?

Link(s) to docdb describing changes (optional)

Is there a docdb describing the issue this solves or the feature added?

@linyan-w linyan-w marked this pull request as ready for review August 14, 2025 14:16
@nathanielerowe
Copy link
Copy Markdown
Contributor

trigger build ci_ref=v10_06_02 LArSoft/lar*@LARSOFT_SUITE_v10_09_00 SBNSoftware/sbncode@v10_09_00 SBNSoftware/sbnalg@v10_09_00 SBNSoftware/sbnobj@v10_01_02 SBNSoftware/sbnanaobj@v10_00_06 SBNSoftware/sbndaq_artdaq_core@v1_10_06 SBNSoftware/sbndata@v01_07 SBNSoftware/sbndutil@v10_06_00_02 SBNSoftware/sbnd_data@v01_34_00

@linyan-w linyan-w removed the request for review from wjdanswjddl September 15, 2025 13:10
Comment thread sbndcode/JobConfigurations/base/detsim_drops.fcl Outdated
@linyan-w linyan-w requested a review from jzennamo September 15, 2025 16:56
@jzennamo
Copy link
Copy Markdown
Contributor

Hero! Approved!

@linyan-w linyan-w moved this from Todo to Reviewer Approved in SBND 2025 Fall Production Sep 15, 2025
@nathanielerowe nathanielerowe moved this from Reviewer Approved to Ready for CI in SBND 2025 Fall Production Sep 16, 2025
@nathanielerowe
Copy link
Copy Markdown
Contributor

trigger build ci_ref=v10_09_00 LArSoft/lar*@LARSOFT_SUITE_v10_10_02 SBNSoftware/sbndaq_artdaq_core@v1_10_06 SBNSoftware/sbnd_data@v01_36_00

@SBNSoftware SBNSoftware deleted a comment from FNALbuild Sep 16, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Sep 16, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Sep 16, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Sep 16, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Sep 16, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Sep 16, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Sep 16, 2025
@SBNSoftware SBNSoftware deleted a comment from FNALbuild Sep 16, 2025
@FNALbuild
Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@nathanielerowe
Copy link
Copy Markdown
Contributor

approved

@nathanielerowe nathanielerowe merged commit 5856149 into develop Sep 16, 2025
@nathanielerowe nathanielerowe moved this from Ready for CI to In tagged release in SBND 2025 Fall Production Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

detsim Detector simulation maintenance

Projects

Status: In tagged release

Development

Successfully merging this pull request may close these issues.

4 participants