Skip to content

Removing XA related ophit and downstream reco for sbndcode issue #821#822

Merged
nathanielerowe merged 7 commits intodevelopfrom
bugfix_remove_xaophit
Oct 6, 2025
Merged

Removing XA related ophit and downstream reco for sbndcode issue #821#822
nathanielerowe merged 7 commits intodevelopfrom
bugfix_remove_xaophit

Conversation

@linyan-w
Copy link
Copy Markdown
Contributor

@linyan-w linyan-w commented Sep 16, 2025 •
edited by jicrespo
Loading

Description

(Temporary) removal of XA related ophit and downstream reco for run1 nominal workflow.
Related to issue 821

Checklist

  • Added at least 1 label from available labels.
  • Assigned at least 1 reviewer under Reviewers,
  • Assigned all contributers including yourself under Assignees
  • Linked any relevant issues under Developement
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
  • Does this affect the standard workflow?
  • Is this PR a patch for the ongoing production? If so, separate PR must also be made for production/v10_06_00 branch!

@linyan-w linyan-w self-assigned this Sep 16, 2025
@linyan-w linyan-w added the pds Photon Detection System label Sep 16, 2025
@linyan-w linyan-w linked an issue Sep 16, 2025 that may be closed by this pull request
Removal or fix of the XA OpHitFinder #821
Closed
4 tasks
@linyan-w linyan-w moved this to Wait for last validation I patch in SBND 2025 Fall Production Sep 16, 2025
@linyan-w linyan-w moved this from Wait for last validation I patch to Wait for next release in SBND 2025 Fall Production Sep 16, 2025
jicrespo
jicrespo requested changes Sep 17, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@jicrespo jicrespo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer if the modules are commented out instead of removing them from the file, so it will be easier to re-enable them once we hace the full X-ARAPUCA system in place. Also, opdecoxarapuca should be commented out as well to avoid deconvolving waveforms that are not reconstructed later.

@jicrespo jicrespo marked this pull request as ready for review September 17, 2025 10:27
@linyan-w linyan-w requested a review from jicrespo September 17, 2025 13:01
@nathanielerowe
Copy link
Copy Markdown
Contributor

nathanielerowe commented Sep 18, 2025

trigger build ci_ref=v10_10_02 LArSoft/lar*@LARSOFT_SUITE_v10_10_02 SBNSoftware/sbndaq_artdaq_core@v1_10_06 SBNSoftware/sbnd_data@v01_36_00

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented Sep 18, 2025

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented Sep 18, 2025

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented Sep 18, 2025

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented Sep 18, 2025

❌ CI build for SBND Failed at phase ci_tests SBND on slf7 for e26:prof - ignored failure for unit_test - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the failed phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@linyan-w linyan-w moved this from Wait for next release (for data) to Wait for last validation I patch (for MC) in SBND 2025 Fall Production Sep 18, 2025
@linyan-w linyan-w moved this from Wait for next validation I patch (for MC) to Wait for validation II in SBND 2025 Fall Production Sep 22, 2025
@nathanielerowe
Copy link
Copy Markdown
Contributor

nathanielerowe commented Oct 1, 2025

trigger build ci_ref=v10_10_03_01 LArSoft/lar*@LARSOFT_SUITE_v10_10_03 SBNSoftware/sbndaq_artdaq_core@v1_10_06 SBNSoftware/sbnd_data@v01_36_00

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented Oct 1, 2025

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented Oct 1, 2025

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented Oct 1, 2025

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented Oct 1, 2025

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored failure for unit_test - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@nathanielerowe
Copy link
Copy Markdown
Contributor

nathanielerowe commented Oct 2, 2025

@linyan-w can you take a look at this error which occurs during CI?

20: %MSG-s ArtException:  PostEndJob 01-Oct-2025 12:01:25 CDT ModuleEndJob
21: ---- EventProcessorFailure BEGIN
22:   EventProcessor: an exception occurred during current event processing
23:   ---- ScheduleExecutionFailure BEGIN
24:     Path: ProcessingStopped.
25:     ---- ProductNotFound BEGIN
26:       Found zero products matching all selection criteria
27:         C++ type: std::vector<recob::OpFlash>
28:         Module label: 'opflashtpc0xarapuca'
29:         Product instance name: ''
30:         Process name: (empty)
31:       The above exception was thrown while processing module FlashPredict/fmatchopara run: 1 subRun: 0 event: 1
32:     ---- ProductNotFound END
33:     Exception going through path reco2
34:   ---- ScheduleExecutionFailure END
35: ---- EventProcessorFailure END
36: ---- FatalRootError BEGIN
37:   Fatal Root Error: TTree::SetEntries
38:   Tree branches have different numbers of entries, eg EventAuxiliary has 0 entries while sim::AuxDetHits_largeant_LArG4DetectorServicevolAuxDetSensitiveCRTStripBERN_G4. has 1 entries.
39:   ROOT severity: 2000
40: ---- FatalRootError END
41: %MSG

@asanchezcastillo
Comment out fm for XArapucas
b3dd2ec 
Comment out fmatchara and fmatchopara in workflow_reco2.fcl
@nathanielerowe
Copy link
Copy Markdown
Contributor

nathanielerowe commented Oct 3, 2025

trigger build ci_ref=v10_10_03_01 LArSoft/lar*@LARSOFT_SUITE_v10_10_03 SBNSoftware/sbndaq_artdaq_core@v1_10_06 SBNSoftware/sbnd_data@v01_36_00

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented Oct 3, 2025

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented Oct 3, 2025

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented Oct 3, 2025

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented Oct 3, 2025

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@nathanielerowe
Copy link
Copy Markdown
Contributor

nathanielerowe commented Oct 3, 2025

trigger build ci_ref=v10_10_03_01 LArSoft/lar*@LARSOFT_SUITE_v10_10_03 SBNSoftware/sbndaq_artdaq_core@v1_10_06 SBNSoftware/sbnd_data@v01_36_00 SBNSoftware/sbnanaobj@v10_00_08

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented Oct 3, 2025

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented Oct 3, 2025

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented Oct 3, 2025

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented Oct 3, 2025

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@nathanielerowe
Copy link
Copy Markdown
Contributor

nathanielerowe commented Oct 4, 2025

trigger build ci_ref=v10_10_03_01 LArSoft/lar*@LARSOFT_SUITE_v10_10_03 SBNSoftware/sbndaq_artdaq_core@v1_10_06 SBNSoftware/sbnd_data@v01_36_00 SBNSoftware/sbnanaobj@v10_00_08 SBNSoftware/sbncode@v10_10_05 SBNSoftware/sbnobj@v10_10_02

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented Oct 4, 2025

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented Oct 4, 2025

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented Oct 4, 2025

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented Oct 4, 2025

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@nathanielerowe
Copy link
Copy Markdown
Contributor

nathanielerowe commented Oct 4, 2025

trigger build ci_ref=v10_10_03_01 LArSoft/lar*@LARSOFT_SUITE_v10_10_03 SBNSoftware/sbndaq_artdaq_core@v1_10_06 SBNSoftware/sbnd_data@v01_36_00 SBNSoftware/sbnanaobj@v10_00_10SBNSoftware/sbncode@v10_10_05 SBNSoftware/sbnobj@v10_10_02

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented Oct 4, 2025

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented Oct 4, 2025

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented Oct 4, 2025

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

@FNALbuild
Copy link
Copy Markdown
Collaborator

FNALbuild commented Oct 4, 2025

⚠️ CI build for SBND Warning at phase ci_tests SBND on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard

🚨 For more details about the warning phase, check the ci_tests SBND phase logs

parent CI build details are available through the CI dashboard

@nathanielerowe
Copy link
Copy Markdown
Contributor

nathanielerowe commented Oct 5, 2025

approved

@nathanielerowe nathanielerowe merged commit 027febc into develop Oct 6, 2025
@linyan-w linyan-w moved this from Wait for validation II to In tagged release in SBND 2025 Fall Production Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jicrespo jicrespo jicrespo approved these changes

@aliciavr aliciavr aliciavr approved these changes

Assignees

@linyan-w linyan-w

Labels

pds Photon Detection System

Projects

SBND 2025 Fall Production
Status: In tagged release

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Removal or fix of the XA OpHitFinder

6 participants

@linyan-w @nathanielerowe @FNALbuild @jicrespo @aliciavr @asanchezcastillo