Skip to content

Veto flashes outside the bnb time window#833

Merged
nathanielerowe merged 3 commits intodevelopfrom
bugfix/acastill_bfm_timeveto
Nov 14, 2025
Merged

Veto flashes outside the bnb time window#833
nathanielerowe merged 3 commits intodevelopfrom
bugfix/acastill_bfm_timeveto

Conversation

@asanchezcastillo
Copy link
Copy Markdown
Contributor

@asanchezcastillo asanchezcastillo commented Sep 26, 2025

Description

This PR changes the BFM workflow from many-to-many matching to one-to-many. Based on ICARUS' experience, this has shown to yield a better matching efficiency (see https://sbn-docdb.fnal.gov/cgi-bin/sso/ShowDocument?docid=33862)

Please provide a detailed description of the changes this pull request introduces.

$${\color{red}!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!}$$

$${\color{red}\bf{\textrm{IMPORTANT UPDATE June 22nd 2025:}}}$$ If you are making a PR which is intended as a patch for the CURRENT production (which started in Spring 2025), you must make two PRs: one for develop and one for the production/v10_06_00 branch.

$${\color{red}!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!}$$

Checklist

  • Added at least 1 label from available labels.
  • Assigned at least 1 reviewer under Reviewers,
  • Assigned all contributers including yourself under Assignees
  • Linked any relevant issues under Developement
  • Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
  • Does this affect the standard workflow?
  • Is this PR a patch for the ongoing production? If so, separate PR must also be made for production/v10_06_00 branch!

Relevant PR links (optional)

Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?

Link(s) to docdb describing changes (optional)

Is there a docdb describing the issue this solves or the feature added?

@linyan-w linyan-w moved this to Wait for validation II in SBND 2025 Fall Production Sep 29, 2025
@asanchezcastillo asanchezcastillo self-assigned this Nov 4, 2025
@asanchezcastillo asanchezcastillo added the enhancement New feature or request label Nov 4, 2025
@asanchezcastillo asanchezcastillo marked this pull request as ready for review November 4, 2025 16:48
@lynnt20
Copy link
Copy Markdown
Contributor

lynnt20 commented Nov 5, 2025

Quick check with Fall Validation sample (many-to-many) and Alejandro's one-to-many sample. BCFM one-to-many has slight performance boost (+2.5% efficiency at same purity for the same intime/bcfm score cuts).

image

@linyan-w linyan-w moved this from Expected for validation II to Reviewer Approved in SBND 2025 Fall Production Nov 10, 2025
@nathanielerowe nathanielerowe merged commit d11e8df into develop Nov 14, 2025
@linyan-w linyan-w moved this from Reviewer Approved to In tagged release in SBND 2025 Fall Production Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: In tagged release

Development

Successfully merging this pull request may close these issues.

4 participants